From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Andy Green <andy@warmcat.com>,
lei.a.yao@intel.com, jerin.jacob@cavium.com
Subject: Re: [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion
Date: Tue, 15 May 2018 15:19:58 +0200 [thread overview]
Message-ID: <1662669.VYcqTo5zqW@xps> (raw)
In-Reply-To: <369bf5db-ad87-73cb-3470-901fe243c4a2@solarflare.com>
15/05/2018 12:51, Andrew Rybchenko:
> On 05/15/2018 10:31 AM, Andy Green wrote:
> > Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy")
> > Signed-off-by: Andy Green <andy@warmcat.com>
>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Suggest to reword it as:
>
> bus/pci: fix invalid size of driver name buffer
>
> Variable dri_name is a pointer and it is incorrect to use its
> size as the buffer size. Caller knows the buffer size and
> it is safer to pass it explicitly.
Applied, thanks
next prev parent reply other threads:[~2018-05-15 13:20 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:47 [dpdk-dev] [PATCH v5 00/16] Fix default build on gcc8.0.1 Andy Green
2018-05-12 1:47 ` [dpdk-dev] [PATCH v5 01/16] devtools/check-git: provide more generic grep pattern Andy Green
2018-05-12 1:47 ` [dpdk-dev] [PATCH v5 02/16] net/nfp: solve buffer overflow Andy Green
2018-05-12 1:47 ` [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code Andy Green
2018-05-15 6:12 ` Yao, Lei A
2018-05-15 7:31 ` [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion Andy Green
2018-05-15 10:51 ` Andrew Rybchenko
2018-05-15 13:19 ` Thomas Monjalon [this message]
2018-05-15 7:32 ` [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code Andy Green
2018-05-15 8:18 ` Yao, Lei A
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 04/16] bus/dpaa: solve inconsistent struct alignment Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 05/16] net/axgbe: solve broken eeprom string comp Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 06/16] net/nfp/nfpcore: solve strncpy misuse Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 07/16] net/nfp/nfpcore: off-by-one and no NUL on strncpy use Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 08/16] net/nfp: don't memcpy out of source range Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 09/16] net/qede: strncpy length constant and NUL Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 10/16] net/qede: solve broken strncpy Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 11/16] net/sfc: make sure that copied stats name is NUL-terminated Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 12/16] net/vdev_netvsc: readlink inputs cannot be aliased Andy Green
2018-05-13 7:20 ` Matan Azrad
2018-05-14 4:54 ` Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 13/16] net/vdev_netvsc: 3 x strncpy misuse Andy Green
2018-05-13 7:47 ` Matan Azrad
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 14/16] app/proc-info: sprintf overrun bug Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 15/16] app/test-bbdev: strcpy ok for allocated string Andy Green
2018-05-12 1:49 ` [dpdk-dev] [PATCH v5 16/16] " Andy Green
2018-05-14 4:59 ` [dpdk-dev] [PATCH v6 00/16] Fix default build on gcc8.0.1 Andy Green
2018-05-14 4:59 ` [dpdk-dev] [PATCH v6 01/16] devtools/check-git: provide more generic grep pattern Andy Green
2018-05-14 16:28 ` Ferruh Yigit
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 02/16] net/nfp: solve buffer overflow Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 03/16] bus/pci: replace strncpy dangerous code Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 04/16] bus/dpaa: solve inconsistent struct alignment Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 05/16] net/axgbe: solve broken eeprom string comp Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 06/16] net/nfp/nfpcore: solve strncpy misuse Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 07/16] net/nfp/nfpcore: off-by-one and no NUL on strncpy use Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 08/16] net/nfp: don't memcpy out of source range Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 09/16] net/qede: strncpy length constant and NUL Andy Green
2018-05-14 20:16 ` Ferruh Yigit
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 10/16] net/qede: solve broken strncpy Andy Green
2018-05-14 20:20 ` Ferruh Yigit
2018-05-14 21:14 ` Ferruh Yigit
2018-05-14 23:04 ` Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 11/16] net/sfc: make sure that copied stats name is NUL-terminated Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 12/16] net/vdev_netvsc: readlink inputs cannot be aliased Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 13/16] net/vdev_netvsc: convert snprintf to strlcpy Andy Green
2018-05-14 5:01 ` [dpdk-dev] [PATCH v6 14/16] app/proc-info: sprintf overrun bug Andy Green
2018-05-14 20:31 ` Ferruh Yigit
2018-05-14 5:01 ` [dpdk-dev] [PATCH v6 15/16] app/test-bbdev: strcpy ok for allocated string Andy Green
2018-05-14 20:42 ` Ferruh Yigit
2018-05-14 20:56 ` Ferruh Yigit
2018-05-14 21:01 ` Ferruh Yigit
2018-05-14 5:01 ` [dpdk-dev] [PATCH v6 16/16] " Andy Green
2018-05-14 21:03 ` Ferruh Yigit
2018-05-14 21:29 ` [dpdk-dev] [PATCH v6 00/16] Fix default build on gcc8.0.1 Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1662669.VYcqTo5zqW@xps \
--to=thomas@monjalon.net \
--cc=andy@warmcat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@cavium.com \
--cc=lei.a.yao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).