From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 4DC491B6D4
for <dev@dpdk.org>; Tue, 15 May 2018 15:20:00 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id DCA3A22620;
Tue, 15 May 2018 09:19:59 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 15 May 2018 09:19:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=YuJT2KKjLhpDenllLKq2zizfZy
BBKVk5Vn9YnPl1wIc=; b=izNEPwNF+LA9aEvJm75d0w6Lgxto3tGsvy441y+yOK
ro+Ff+HFDE+Q6tsQWcsb9mG3am8fRseMpm67Rlu3jfmJtPmUKgRMAPQfvjKAxHf9
+EHZTWLJ1+nj0ALSUJHdX80uZeCug9FbWSdRZGYvFT47fvcdCyahA1DkFYunH4GW
8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YuJT2K
KjLhpDenllLKq2zizfZyBBKVk5Vn9YnPl1wIc=; b=K5Tx+TnQb8oOZlSAaxiRyp
rlLqijGro/1PUdydpEfa4zvLc8KmWfkgpVTKbL0+FN8iwQe2nfdxGUgySrh34+cF
E3HTUOC9ENT3MM70B3ZIRDZfRoETIE6fTE09H1g2hXvvto613hmxBkpOwpaoYoEJ
UgrF+QXYXjHlhSY9gQs8uArNU+EZ1WT/L/Bdi8rWoD18QZUH/5QalH8r2OMQvJhI
dKltxfANahrGKBc0UfBLoSGKmqXboprU0/qqVzYZ3It35ogXwoy+71hdD9ZwAwoK
8B3ORTWqAbuFKaWRx+6hu893VFBulMrF4Oio8/a/RVx6qVRNMDZtp4OJJ5Y8kUIw
==
X-ME-Sender: <xms:f976WsXJaCFac2gc75HXNsnoClL20DrNZzZBxv0QRqqJP-KtP4QdnA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 0FE62E5038;
Tue, 15 May 2018 09:19:58 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Andy Green <andy@warmcat.com>, lei.a.yao@intel.com,
jerin.jacob@cavium.com
Date: Tue, 15 May 2018 15:19:58 +0200
Message-ID: <1662669.VYcqTo5zqW@xps>
In-Reply-To: <369bf5db-ad87-73cb-3470-901fe243c4a2@solarflare.com>
References: <2DBBFF226F7CF64BAFCA79B681719D953A44992E@SHSMSX101.ccr.corp.intel.com>
<152636946035.95095.1840276672620244597.stgit@localhost.localdomain>
<369bf5db-ad87-73cb-3470-901fe243c4a2@solarflare.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy
conversion
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 May 2018 13:20:00 -0000
15/05/2018 12:51, Andrew Rybchenko:
> On 05/15/2018 10:31 AM, Andy Green wrote:
> > Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy")
> > Signed-off-by: Andy Green <andy@warmcat.com>
>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Suggest to reword it as:
>
> bus/pci: fix invalid size of driver name buffer
>
> Variable dri_name is a pointer and it is incorrect to use its
> size as the buffer size. Caller knows the buffer size and
> it is safer to pass it explicitly.
Applied, thanks