From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 93E2B3B5 for ; Mon, 15 May 2017 11:33:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F3D1A207CD; Mon, 15 May 2017 05:33:18 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 15 May 2017 05:33:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=40mKzxI22YXS++E /ChJstAomspRooGXy/lg2U9teZxY=; b=L8Adg+5ke2QjXUUK8G/1JTz6UqOEdh8 cdrN9dwwRn+pDkt99Ki6uUlstjiWipS40gVVgHKQGmCn82wlamStt6c+wh9vkFs6 ALug6pdPx4YoQWC4/by9gvQCHgALTN2I4x9RUQ/bnscq+8dP1VLM82lYWpa2E739 yAt7rOHabg5k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=40mKzxI22YXS++E/ChJstAomspRooGXy/lg2U9teZxY=; b=WM0BN0nW o2Yd+eBavZ8B02xp/XzKhNkdaMRvITX5XKdvXqrso9MtKNJcobt9ffvQ/TrzrJXt jFZtAY31j705Kdq/2WMuzHSapNtAFykMM5MWChNzWqtyVR1RDDm3Px66ezVA6BDY BM9mO/bx/ryrRqsFKRWfufRx/TB8+ANusL/o/YdwIEcpaq/3xp2qA7rWZpaTXnDV WHrIVu0lRHCzn/AQ/OP7tMIFaDgxcqnIPsgQwfzICy087DyaeRsitwmgzhFWE1iK A7Y9nB98qOk7EeHYgDFzRzbA9UWZmwI+WtU40ty/ou5SeJbT+92Y7lZVoPrdv4Di 1cPBgWYnQcPEuA== X-ME-Sender: X-Sasl-enc: Bx7mZ+xLFgYZND/yQHDVMIWkRg3r5JZQ5EFF56b28rgl 1494840798 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 986BA24996; Mon, 15 May 2017 05:33:18 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Shepard Siegel , Ed Czeck , John Miller , John McNamara , Harish Patil , Rasesh Mody , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Jing Chen , Helin Zhang , Jingjing Wu , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Matej Vido , Pascal Mazon , Yuanhan Liu , Maxime Coquelin , Shrikrishna Khare Date: Mon, 15 May 2017 11:33:17 +0200 Message-ID: <1664240.MkSOEDHSV8@xps> In-Reply-To: References: <20170510131053.75843-1-ferruh.yigit@intel.com> <17406199.hqjMraK9H2@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 May 2017 09:33:19 -0000 15/05/2017 10:40, Ferruh Yigit: > On 5/12/2017 4:48 PM, Thomas Monjalon wrote: > > 12/05/2017 12:49, Ferruh Yigit: > >> On 5/10/2017 2:51 PM, Thomas Monjalon wrote: > >>> 10/05/2017 15:10, Ferruh Yigit: > >>>> --- a/doc/guides/nics/features/bnx2x.ini > >>>> +++ b/doc/guides/nics/features/bnx2x.ini > >>>> @@ -4,6 +4,7 @@ > >>>> ; Refer to default.ini for the full list of available PMD features. > >>>> ; > >>>> [Features] > >>>> +Speed capabilities = Y > >>> > >>> We should validate this feature only if the driver advertise the > >>> right speeds for the device. > >> > >> Hi Thomas, > >> > >> Can you please clarify more, what is expected implementation in PMD? > > > > It is expected to advertise only the speeds that the device is > > capable to offer. > > > >> And perhaps a good and a bad sample can be helpful. > > > > Good example: > > drivers/net/i40e/i40e_ethdev.c > > if (I40E_PHY_TYPE_SUPPORT_40G(hw->phy.phy_types)) > > /* For XL710 */ > > dev_info->speed_capa = ETH_LINK_SPEED_40G; > > else if (I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types)) > > /* For XXV710 */ > > dev_info->speed_capa = ETH_LINK_SPEED_25G; > > else > > /* For X710 */ > > dev_info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G; > > > > Bad example: > > drivers/net/bnx2x/bnx2x_ethdev.c > > dev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G; > > Looking at qlogic.com, only some 57840 adapters are capable of 20G. > > OK, I will update the patch according. > > Does it make sense to mark PMDs that report speed_capabilities, but > without checking actual hw, as partial "P", to differentiate them from > the ones that doesn't report at all, also this may help to PMD > maintainers about what to fix. Yes, we can use partial "P" here.