From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix meson build test to exit on failure
Date: Wed, 13 Mar 2019 11:03:41 +0100 [thread overview]
Message-ID: <1664387.3Zkg7kFagz@xps> (raw)
In-Reply-To: <20190312101828.18817-1-bruce.richardson@intel.com>
12/03/2019 11:18, Bruce Richardson:
> When piping the ninja command through cat, we lose the error value from
> the call to ninja in the case of failure. This prevents the script from
> exiting at the first broken build. Fix this by setting the "pipefail"
> shell option.
>
> Fixes: 4bcb9b768604 ("devtools: add verbose option to meson build test")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-03-13 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 10:09 [dpdk-dev] [PATCH] " Bruce Richardson
2019-03-12 10:18 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2019-03-13 10:03 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1664387.3Zkg7kFagz@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).