From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B69CBA052A; Tue, 26 Jan 2021 16:50:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D125140D41; Tue, 26 Jan 2021 16:50:30 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 9D14C140D22 for ; Tue, 26 Jan 2021 16:50:28 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 0EDCC5C0156; Tue, 26 Jan 2021 10:50:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 26 Jan 2021 10:50:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= rAh6PIVnGL4SiMW9wseEtJxQr0wlfqclStijTUMa9oc=; b=hi4OT8nxhoCccWs5 znHfcBTA1FDz52GolxeiXccAivfuSDyr+jcZ/QYkcXbfVtUYbeNpjt31561EJ2Z1 WNU0FgCtcPwvRENpI+ZL9XI0BylfuLZLISsxuxLpnu5ePp/DEWAI3OJK15IdegYl mQoB8Dk9hfENf45jJbfMB1oQwfgfcqWAb2NjqLuswBcYm6SRuJVUN9C/M7FE0/lk DHaj9cse9FK+ke1damJ21W5O6r9SDW5oergjRKRonwqa1uTAzVwBfBThOmNM8mdb cex2mnRn8oxVUqJ1DRN8wFwvrgxnCsMuGQGFx5gIQOHXvKHog3fyVaaLiQ0PzMik ozX9wA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rAh6PIVnGL4SiMW9wseEtJxQr0wlfqclStijTUMa9 oc=; b=UcQYrrnnZY7gngH89Hf1OJAWqw3rqFCswIrpqE4RCEv8p23GZ6fsOvfhU sZczpk5E6zz094HZNTfXU8NXFFB3PM4IFD6+qd8G67KLqalSYvkGAnpMR4SLyzZa ULJLjsWlF1UeR/avgX1hwFKrr1NI4ZQlsVsUzPfPTVZd6zgwXYZrebDmeG4AIeyl 4fny7knuD/foafamHEeI/UzSSvtj//ijbVIrEHo8LYOJrCvCSmEzQi3jCfQfrJ1w g8Y5/kGD9Nw4KpBbf0sPdc1fw8fCVrc3ydY2dGtuqFXOyttnsCjCQ4cq9POFLYxn JMHPmMrC7n9Q8iq9zjS/C0FVXOQGg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeigddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 06548240057; Tue, 26 Jan 2021 10:50:26 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: David Marchand , dev , ferruh.yigit@intel.com Date: Tue, 26 Jan 2021 16:50:26 +0100 Message-ID: <1666065.0iZHQibpWB@thomas> In-Reply-To: <20210126154230.GE239@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <2592228.fJoplo53l3@thomas> <20210126154230.GE239@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/01/2021 16:42, Bruce Richardson: > On Tue, Jan 26, 2021 at 04:31:36PM +0100, Thomas Monjalon wrote: > > 26/01/2021 15:39, Bruce Richardson: > > > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does indeed > > > throw up the errors with clang - but not gcc, which is strange. The > > > offending headers seem to be (initially): > > > > > > * rte_ethdev_vdev.h > > > * rte_ethdev_pci.h > > > > > > Are these public header files, or should they skip header checking - and > > > installation - as internal-only? > > > > They are helpers for the drivers, so should be internal. > > > Just to confirm, by that you mean that they should not be installed for > end-application use? I think yes they are not needed to be installed. > In which case, I believe that "rte_ethdev_driver", "rte_ethdev_vdev" and > "rte_ethdev_pci" should be removed from the "headers" list in > "librte_ethdev/meson.build". Current file list there is: > > headers = files('rte_ethdev.h', > 'rte_ethdev_driver.h', > 'rte_ethdev_pci.h', > 'rte_ethdev_trace.h', > 'rte_ethdev_trace_fp.h', > 'rte_ethdev_vdev.h', > 'rte_dev_info.h', > 'rte_flow.h', > 'rte_flow_driver.h', > 'rte_mtr.h', > 'rte_mtr_driver.h', > 'rte_tm.h', > 'rte_tm_driver.h') > headers_no_chkincs += files('rte_eth_ctrl.h', > 'rte_ethdev_core.h') > > [Note that the "headers_no_chkincs" files still get installed, they just > skip header checking as indirect includes.] > Anything else that should be removed. > > Also, tangential to this, it would probably be good if we could come up > with a different naming scheme for internal-only headers, to make the > difference between what is to be installed or not, a lot clearer! The difference is supposed to be the rte_ prefix in the file name. Doxygen will parse only these files: FILE_PATTERNS = rte_*.h cmdline.h I agree we should fix the internal filenames and not install them.