From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zyta Szpak <zr@semihalf.com>
Cc: Remy Horton <remy.horton@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes
Date: Fri, 17 Jun 2016 12:20:18 +0200 [thread overview]
Message-ID: <1667158.opORKPN5aG@xps13> (raw)
In-Reply-To: <575ED666.2010509@intel.com>
2016-06-13 16:51, Remy Horton:
>
> On 12/06/2016 15:51, Zyta Szpak wrote:
> > I would prefer having only one function rte_eth_dev_get_regs()
> > which returns length and width if data is NULL.
> > The first call is a parameter request before buffer allocation,
> > and the second call fills the buffer.
> >
> > We can deprecate the old API and introduce this new one.
> >
> > Opinions?
> >
> > In my opinion as it is now it works fine. Gathering all parameters in
> > one callback might be a good idea if the maintainer also agrees to that
> > because as I mentioned, it interferes.
>
> From my perspective changing rte_eth_dev_get_regs() isn't a problem, as
> it isn't used directly rather than through rte_ethtool_get_regs()..
Zyta, would you like to make a v4?
next prev parent reply other threads:[~2016-06-17 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 7:56 zr
2016-06-01 7:56 ` [dpdk-dev] [PATCH v3 2/2] examples/ethtool: get reg width to allocate memory zr
2016-06-07 9:52 ` Remy Horton
2016-06-07 9:52 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes Remy Horton
2016-06-08 8:53 ` Thomas Monjalon
2016-06-12 14:51 ` Zyta Szpak
2016-06-13 15:51 ` Remy Horton
2016-06-17 10:20 ` Thomas Monjalon [this message]
2016-06-21 9:55 ` Zyta Szpak
2016-06-22 8:19 ` Zyta Szpak
2016-06-22 8:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667158.opORKPN5aG@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).