From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 70BEA95CB for ; Fri, 17 Jun 2016 12:20:20 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id v199so224228247wmv.0 for ; Fri, 17 Jun 2016 03:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=l59p20oaIsylT/4NgcKOoSj0EWtXQkOWpm/D0y6hV1c=; b=cS7nP1c9RbYT3wb6lZbZbNvH4lJNhDAFAoaM9Pfvkkt7xUyjicXskmjQiOoafFUDa4 uZCTw+p5ci35fE2wHD770Zkop4QKgAt3OmuftbFcjYlP4plxdL/9/j658+OvwAyKrM/4 t8RvKUo5DW7KAuw+RG4KSx/y3Yfr2mtqicVmPaxTVl6oNOYAr/xAHFtJChukqZWyXHj5 FjFyhw8w+dfOLceH3yZzwx8Zd74TdhJv85RGdIHdvRJZAwt4GXKvGpU/nQJE/SkpOGsA 5piuHT6u8hUqhKtCqaqDZnyG6W/BbaEpA6mjKY6PoNZ5XAc89EpkBp0Az4/++qK4R79O p3nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=l59p20oaIsylT/4NgcKOoSj0EWtXQkOWpm/D0y6hV1c=; b=YJ+1SbD/QcvkiaDq1ThJpKO7pQq5gzLHR7MOitzCjI6H6ODAr4wV1q5RvOkBGiWO7o nL005NmtI6cDp9Vx2/2hmvSszRwFTi0fzROb+brW6cewZcU3Ejqf8iLAHYaEOEQ8655o GYv8RsuYGXsmlgpH64VmVTDbS6Rejah5YJdWSlL2s+/jOKhVCYIySH0IarYhqSiADuwr CamS0fns3eIY6F2KVOwal3pWzuY8XbfXnamiTaCoo3hTRRFvC7gVShjXCnAMgn/u6qKk MV/OGvZqFpZchC59y8jOXN9lmZdXh4IArrSo6bMpg3+oc5+uRTLkpZqta3mnMr+mLbQC m8Jg== X-Gm-Message-State: ALyK8tJ468e5yXeWNo5ibQmTAHCaiQqDS3yeltiGx7DAduybF9RNis0usYgwBoEEvRZgSufg X-Received: by 10.28.30.149 with SMTP id e143mr1490362wme.81.1466158820206; Fri, 17 Jun 2016 03:20:20 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id n66sm19298983wmn.7.2016.06.17.03.20.19 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 03:20:19 -0700 (PDT) From: Thomas Monjalon To: Zyta Szpak Cc: Remy Horton , dev@dpdk.org Date: Fri, 17 Jun 2016 12:20:18 +0200 Message-ID: <1667158.opORKPN5aG@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <575ED666.2010509@intel.com> References: <1464767771-19159-1-git-send-email-zr@semihalf.com> <575ED666.2010509@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 10:20:20 -0000 2016-06-13 16:51, Remy Horton: > > On 12/06/2016 15:51, Zyta Szpak wrote: > > I would prefer having only one function rte_eth_dev_get_regs() > > which returns length and width if data is NULL. > > The first call is a parameter request before buffer allocation, > > and the second call fills the buffer. > > > > We can deprecate the old API and introduce this new one. > > > > Opinions? > > > > In my opinion as it is now it works fine. Gathering all parameters in > > one callback might be a good idea if the maintainer also agrees to that > > because as I mentioned, it interferes. > > From my perspective changing rte_eth_dev_get_regs() isn't a problem, as > it isn't used directly rather than through rte_ethtool_get_regs().. Zyta, would you like to make a v4?