From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 517BCA0C55; Wed, 13 Oct 2021 11:40:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17C92410DA; Wed, 13 Oct 2021 11:40:17 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id D238640150 for ; Wed, 13 Oct 2021 11:40:15 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3AB365C01D2; Wed, 13 Oct 2021 05:40:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 13 Oct 2021 05:40:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= XLm4klKd5GcxvfnmBIBrBnzRPFYIK4lwxKsfAFbeFoo=; b=iMTSJRoN6we/2mni C9532axDcI4MoIHqkAUtlmwsiB3RqSCzrU8Q4OcuGwRRRMydMAqQ2YL3vb4LWCpo RS/+sOeOEW7uL+MBeYCbEYcGVfFkb3f/OgE8R3kHCFaJevlAxc977LuoBSGqGh7T xthjEv7t9vZf6QKgwPcolKpfPK5DhBEjNJxD+jOCsZ3eRW6/XcupQAZ+6uYPRLdA I3X3KpZMvL5+XWFbMrQnBHPcIkbDSbBMcBOIU20j6gMqGRu6n4NrAqPQl0owDRE0 rjjbsb6gFzN89hoPS4qFue/kjlj+jzPfKYKO6jmoA2KzFGgjivppGxFeXfT7oaqR T1OYZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XLm4klKd5GcxvfnmBIBrBnzRPFYIK4lwxKsfAFbeF oo=; b=dyhzRdorc2Qei2/gbxyGyu4s1QqmN6X0h688Q/s7+UsIkfnxuNHrU6OfH E8Nwz7CXZKvs8OOCsyeklk5hy8IQTZDKSxklaEgisskwi+xayfJg99TG5NZs6PQf Cv48qoDDUZEPynndnuMTULOiMimBpLX8/IgDvKs4H/6KpaZptgWCJFoR0lPfR7XY xlEWBzUI5hQ0j7egRRSeWE930dCyHphDXfV2U6oKRtRVGKRk6DV4sKfzq1oNqdug ZOF7bMiZ1K6rkUUHbFkXrjUI4wuKEEABNl7mnoY+Fm5zBng3tu/nfOAyvNtBqsSL +FpvPEAikngn8WwZLq2yWGrzNZ7bQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 05:40:13 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , "Kinsella, Ray" Cc: "dev@dpdk.org" , "Zhang, Roy Fan" , "Singh, Jasvinder" , david.marchand@redhat.com Date: Wed, 13 Oct 2021 11:40:09 +0200 Message-ID: <1667999.ADG73FIASF@thomas> In-Reply-To: References: <20210901122007.3885050-1-jasvinder.singh@intel.com> <1673065.JLNdA3veM0@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/10/2021 10:51, Kinsella, Ray: > > On 12/10/2021 22:52, Thomas Monjalon wrote: > > 12/10/2021 22:34, Dumitrescu, Cristian: > >> From: Thomas Monjalon > >>> 01/09/2021 14:20, Jasvinder Singh: > >>>> These APIs were introduced in 18.05, therefore removing > >>>> experimental tag to promote them to stable state. > >>>> > >>>> Signed-off-by: Jasvinder Singh > >>>> --- > >>>> lib/pipeline/rte_port_in_action.h | 10 ---------- > >>>> lib/pipeline/rte_table_action.h | 18 ------------------ > >>>> lib/pipeline/version.map | 16 ++++++---------- > >>>> 3 files changed, 6 insertions(+), 38 deletions(-) > >>> > >>> Cristian, please can you check whether you intend to keep these functions in > >>> future? > >>> If they are candidate to be removed, there is no point to promote them. > >> > >> Hi Thomas, > >> > >> Yes, they are candidate for removal, as the new rte_swx_pipeline API evolves. > >> > >> But removing them requires updating the drivers/net/softnic code to use the new API, which is not going to be completed in time for release 21.11. > >> > >> So given this lag, it might be better to simply promote these functions to stable API now, as Ray suggests, instead of continuing to keep them experimental; then, once these functions are no longer used, then we can remove them, most likely in 22.11. > >> > >> So I will ack these patches, but I am willing to reconsider if you feel strongly against this approach. > > > > I think we should not promote API that we know will disappear soon. > > The stable status means something for the users. > > Ray, what is your opinion? > > > > Well - I agree with Cristian (he and I discuss this a few weeks ago). > My position is if you are going to maintain an API, that means giving a few guarantees. > The API's have been experimental for 3 years ... at what point do they mature? > > However, I agree there is two ways to look at this thing, I try to be pragmatic. > Maturing of any ABI/API is a conversation between a maintainer and the contributor. > If they strongly feel, it is a pointless exercise - I won't argue. I think you did't get it. This API will be removed soon. That's why I think it doesn't make sense to make them stable, just before removing.