From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83E1142BE3; Tue, 30 May 2023 15:16:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18E7640A82; Tue, 30 May 2023 15:16:25 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 63D73406BC for ; Tue, 30 May 2023 15:16:23 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 135E53200893; Tue, 30 May 2023 09:16:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 30 May 2023 09:16:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1685452579; x=1685538979; bh=k2gVgGqVJ6OEPShIG/QvstnQx50hUghY0Ib znNg0K1g=; b=rVjyhmzKm3O3zLqy3cus5CcwpryoSiai8W4cqJ7cCr5pwwkrR/v zdXT7Mon6tQzgupxPo6628FxxqS1azKgYme4P1HTYG4CcVznpnwND6Tival0HcrZ fIbxPE8EjiFA6H3q9imDhHpVgSEdakuCnOsBADFUEovlEmZQMyXlhOjrRiGFF0pt lhd+ahDcPefH7Srl4UK8+l6PfOp2wmYBxAWnl2XEVF5XG9hJKakTggLEdVe9mVng WjgdIiM/biCHDbUCn7+OG3zTx8/J0vIDbNGqJqguT4WtpCRiAUAk0GDs6Axl3dBX GnVIu59RhOWqguEc0C0d9Eis9iOAs66Y0WQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685452579; x=1685538979; bh=k2gVgGqVJ6OEPShIG/QvstnQx50hUghY0Ib znNg0K1g=; b=pRqdwdeNwpl/aPbzgexYWgb3dUXWI8H4YjWy4WWD4MsXOecc0Cr CobzMR9W8xD72SkZoH7KWUzF7SFgVald5ADmrFQCkxTBfCrbmOD+vpqkPk2/B1hJ OM8eZ1ohZrvitPG8wXY9Dvrva8dpa9ZJRn0sbQNkygSLavvNyGqeC0jP0NZMNmNm VJzGUQnTEyWYlRGPb81y/oh9fbV+Qery1+CfQ9ARbrvEZ9CUqw4YgURUFrP657C/ WR2W55+jjcpCRYJp58U9GWoC4CN8Awfd2Z8+rUxR1PYCL2W8Rtm93u6KgPrAaoeK YgIlWxoGOyXywmQV+msvbF5KkvVYVBcOksQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeekjedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 May 2023 09:16:18 -0400 (EDT) From: Thomas Monjalon To: Eelco Chaudron , chenbo.xia@intel.com, david.marchand@redhat.com, Maxime Coquelin Cc: dev@dpdk.org Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick Date: Tue, 30 May 2023 15:16:17 +0200 Message-ID: <16690234.Ash8RoxBsO@thomas> In-Reply-To: <49ec9930-66b8-fc95-72ad-5cb012ed8635@redhat.com> References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431455219.558450.14986601389394385835.stgit@ebuild.local> <49ec9930-66b8-fc95-72ad-5cb012ed8635@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 30/05/2023 15:02, Maxime Coquelin: > > On 5/17/23 11:09, Eelco Chaudron wrote: > > This patch adds an operation callback which gets called every time the > > library wants to call eventfd_write(). This eventfd_write() call could > > result in a system call, which could potentially block the PMD thread. > > > > The callback function can decide whether it's ok to handle the > > eventfd_write() now or have the newly introduced function, > > rte_vhost_notify_guest(), called at a later time. > > > > This can be used by 3rd party applications, like OVS, to avoid system > > calls being called as part of the PMD threads. > > > > Signed-off-by: Eelco Chaudron > > --- > > lib/vhost/meson.build | 2 ++ > > lib/vhost/rte_vhost.h | 23 +++++++++++++++++- > > lib/vhost/socket.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++--- > > lib/vhost/version.map | 9 +++++++ > > lib/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++ > > lib/vhost/vhost.h | 58 ++++++++++++++++++++++++++++++++------------- > > 6 files changed, 171 insertions(+), 22 deletions(-) > > > > > The patch looks good to me, but that's the first time we use function > versioning in Vhost library, so I'd like another pair of eyes to be sure > I don't miss anything. > > Reviewed-by: Maxime Coquelin > > Thomas, do we need to mention it somewhere in the release note? If compatibility is kept, I think we don't need to mention it.