From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E432A00C2; Sat, 25 Apr 2020 19:26:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6BED1C196; Sat, 25 Apr 2020 19:26:24 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 39C5F1BF8A for ; Sat, 25 Apr 2020 19:26:23 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C121D5C017F; Sat, 25 Apr 2020 13:26:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 25 Apr 2020 13:26:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 49qwkOCPL650ETt65ISDLl1oNZO8gj7oXisGrY9VhC4=; b=oBTpLndk+bz6xTou +TnABV2TMGPFxWRiRjIohyXEaFnjTwBKB4k6KpDEWC2oc9NZBNEFONup7Fy4/en2 XvZdZHSLePWo61Ph4CPKLpcmI6LEzw1f1eny//1mNhU5sv/KP6B/NRbOeIon7drj xoM3bAJT/eNUWaM9ejhEOXAYJHf2XOB5BAgWUJYJ1dFWqa+0gAZkk4G0fw+jcvju RIxvynxfutirbdE4+jrHedsHdQh7xE9qjzJl3atLO87EJLu1b/s5uwFEXh14dPIW y9TRDP3UqdbemynmUQ0SRO1I32V2/YX3eizS48c9XJtK13xis6rezQEXHmlrNU8r fvHZ9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=49qwkOCPL650ETt65ISDLl1oNZO8gj7oXisGrY9Vh C4=; b=K6WcQgfbN0tCLCnUKxQwevogWU8gha3MqKAd23x7bDLtL1FZXem3EIyLa /BzkrZjRQZjlEHe5KXI3RxtH7QhYsbxcvADyxVMlptzVkOa4gVTqqhsCf6AEQ7Cg XQ6Oqs0fwCE2/9XNBV32rvAYVp+g8Ga7hB/Moi7N4ufuE0uhq7yQ6JaQHr6mljST J1hv7MMENzJuWESPfUlww2UuSK8pH+41eLtD1U26mQGefp/HWrRjznjtS6BDWTkh CKC0pQq5A0fPdCGN8He8O078goKZCu/J6o+KG3H8LIoHGSlh7qC76H5PCEzig05A JlDRVH/U3asRtQDwFjbhIRo9dRa4Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheeggdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8E5E9328005E; Sat, 25 Apr 2020 13:26:21 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, olivier.matz@6wind.com, mattias.ronnblom@ericsson.com, david.marchand@redhat.com Date: Sat, 25 Apr 2020 19:26:20 +0200 Message-ID: <1670760.OQMrUlzKSU@thomas> In-Reply-To: <20200412150427.2786199-1-jerinj@marvell.com> References: <20200412144047.2125201-1-jerinj@marvell.com> <20200412150427.2786199-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] doc: use glob terminology X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/04/2020 17:04, jerinj@marvell.com: > --- a/devtools/check-includes.sh > +++ b/devtools/check-includes.sh > @@ -23,7 +23,7 @@ > # PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict > # C/C++ compilation flags. > # > -# IGNORE contains a list of shell patterns matching files (relative to the > +# IGNORE contains a list of glob matching files (relative to the > # include directory) to avoid. It is set by default to known DPDK headers > # which must not be included on their own. > # > diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h > index a497e195d..fa60177c0 100644 > --- a/lib/librte_eal/include/rte_log.h > +++ b/lib/librte_eal/include/rte_log.h > @@ -158,7 +158,7 @@ __rte_experimental > bool rte_log_can_log(uint32_t logtype, uint32_t loglevel); > > /** > - * Set the log level for a given type based on shell pattern. > + * Set the log level for a given type based on glob. > * > * @param pattern > * The match pattern identifying the log type. My comment on v1 was sent at the same time as this v2. Pasting it here: "match pattern" can be replaced with "globbing pattern". I think there are few other places which can be improved. I see this one in lib/librte_eal/common/eal_common_log.c: glob (file match) pattern I suggest "globbing pattern" And "Glob match string option" -> "Globbing pattern option"