From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: fix unintended sign extension
Date: Tue, 15 Dec 2015 18:07:30 +0100 [thread overview]
Message-ID: <1671518.qOKSgfYHRV@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE202407509@IRSMSX103.ger.corp.intel.com>
> Coverity issue reported like
> > CID 119268 (#1 of 1): Unintended sign extension
> > (SIGN_EXTENSION)sign_extension: Suspicious implicit sign extension:
> > vsi_id with type unsigned short (16 bits, unsigned) is promoted in vsi_id
> > << 23 to type int (32 bits, signed), then sign-extended to type unsigned
> > long (64 bits, unsigned). If vsi_id << 23 is greater than 0x7FFFFFFF, the
> > upper bits of the result will all be 1.
> >
> > Fixes: 88ebc2b7f976 ("i40e: extend flow director to support VF")
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-12-15 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 16:23 Jingjing Wu
2015-12-15 17:01 ` Mcnamara, John
2015-12-15 17:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1671518.qOKSgfYHRV@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).