From: Thomas Monjalon <thomas@monjalon.net>
To: ilia.kurakin@intel.com
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
keith.wiles@intel.com, dmitry.galanov@intel.com
Subject: Re: [dpdk-dev] [PATCH v7] ether: add support for vtune task tracing
Date: Fri, 22 Sep 2017 12:42:33 +0200 [thread overview]
Message-ID: <1671807.t1LnDJUZi1@xps> (raw)
In-Reply-To: <20170908125721.2878-1-ilia.kurakin@intel.com>
08/09/2017 14:57, ilia.kurakin@intel.com:
> + /* See rte_ethdev_profile.h to find comments on code below. */
> + __rte_eth_profile_rx_init(port_id, dev);
We can find easily where the function is defined.
Please replace this comment by something like that:
/* Initialize Rx profiling if enabled at compilation time. */
Why not checking an error code for this initialization?
If we enable it, we expect the application to abort if
the profiling does not work.
> --- /dev/null
> +++ b/lib/librte_ether/rte_ethdev_profile.h
This file is internal so it should not appear in doxygen index.
Please remove rte_ prefix from the filename to blacklist it from
doxygen point of view.
You can apply the same change to the .c file for consistency.
next prev parent reply other threads:[~2017-09-22 10:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 17:18 [dpdk-dev] [PATCH] " ilia.kurakin
2017-06-22 9:42 ` Ananyev, Konstantin
2017-06-22 12:12 ` Kurakin, Ilia
2017-06-22 16:46 ` Galanov, Dmitry
2017-06-27 13:16 ` ilia.kurakin
2017-06-30 3:30 ` Jerin Jacob
2017-06-30 10:13 ` Ananyev, Konstantin
2017-07-06 16:42 ` [dpdk-dev] [PATCH v2] " ilia.kurakin
2017-07-10 12:30 ` Jerin Jacob
2017-07-11 17:24 ` [dpdk-dev] [PATCH v3] The patch adds tracing of loop iterations that yielded no packets in a DPDK application. It is using ITT task API: https://software.intel.com/en-us/node/544206 ilia.kurakin
2017-07-11 17:48 ` [dpdk-dev] [PATCH v3] ether: add support for vtune task tracing ilia.kurakin
2017-07-14 5:45 ` Jerin Jacob
2017-07-17 17:15 ` [dpdk-dev] [PATCH v4] " ilia.kurakin
2017-07-19 8:54 ` [dpdk-dev] [PATCH v5] " ilia.kurakin
2017-07-24 9:27 ` Jerin Jacob
2017-07-24 12:33 ` Kurakin, Ilia
2017-09-22 10:19 ` Thomas Monjalon
2017-07-24 17:06 ` [dpdk-dev] [PATCH v6] " ilia.kurakin
2017-09-08 12:57 ` [dpdk-dev] [PATCH v7] " ilia.kurakin
2017-09-22 10:42 ` Thomas Monjalon [this message]
2017-09-22 14:52 ` [dpdk-dev] [PATCH v8] " ilia.kurakin
2017-09-22 17:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1671807.t1LnDJUZi1@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.galanov@intel.com \
--cc=ilia.kurakin@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).