* [dpdk-dev] [PATCH] ivshmem: fix segmentation fault in corner case
@ 2015-06-18 12:27 Sergio Gonzalez Monroy
2015-06-22 16:40 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Sergio Gonzalez Monroy @ 2015-06-18 12:27 UTC (permalink / raw)
To: dev
Depending on the configured segments it is possible to hit a
segmentation fault as a result of decrementing an unsigned index with
value 0.
To avoid it, exit the loop if the index has value 0.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
lib/librte_ivshmem/rte_ivshmem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_ivshmem/rte_ivshmem.c b/lib/librte_ivshmem/rte_ivshmem.c
index 7ca55ed..9621906 100644
--- a/lib/librte_ivshmem/rte_ivshmem.c
+++ b/lib/librte_ivshmem/rte_ivshmem.c
@@ -377,6 +377,8 @@ build_config(struct rte_ivshmem_metadata * metadata)
for (j = biggest_idx - 1; j >= i; j--) {
memcpy(&pages[j+1], &pages[j], sizeof(struct rte_memseg));
memset(&pages[j], 0, sizeof(struct rte_memseg));
+ if (j == 0)
+ break;
}
/* put old biggest segment to its new place */
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-22 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-18 12:27 [dpdk-dev] [PATCH] ivshmem: fix segmentation fault in corner case Sergio Gonzalez Monroy
2015-06-22 16:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).