From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet identification
Date: Wed, 27 Aug 2014 16:58:46 +0200 [thread overview]
Message-ID: <1672259.DZkGQ2cZmA@xps13> (raw)
In-Reply-To: <1409038294-21693-2-git-send-email-jijiang.liu@intel.com>
Hi Jijiang,
2014-08-26 15:31, Jijiang Liu:
> VxLAN UDP port configuration on i40e, which include
> - VxLAN UDP port initialization
> - add APIs to configure VxLAN UDP port
Actually you should explain that you introduce tunnels
and first one is VxLAN.
> lib/librte_ether/rte_ethdev.c | 63 ++++++++++++
> lib/librte_ether/rte_ethdev.h | 76 ++++++++++++++
> lib/librte_ether/rte_ether.h | 10 ++
> lib/librte_pmd_i40e/i40e_ethdev.c | 199 ++++++++++++++++++++++++++++++++++++-
> lib/librte_pmd_i40e/i40e_ethdev.h | 5 +
Changing ethdev API is so sensible that it deserves a separated commit.
Code seems OK.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-08-27 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 7:31 [dpdk-dev] [PATCH v2 0/7]]Support VxLAN on Fortville Jijiang Liu
2014-08-26 7:31 ` [dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet identification Jijiang Liu
2014-08-27 14:58 ` Thomas Monjalon [this message]
2014-08-28 1:33 ` Liu, Jijiang
2014-08-28 8:33 ` Thomas Monjalon
2014-08-26 7:31 ` [dpdk-dev] [PATCH v2 2/7]]app/test-pmd:test " Jijiang Liu
2014-08-26 7:31 ` [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet filter in librte_ether Jijiang Liu
2014-08-27 15:12 ` Thomas Monjalon
2014-08-28 0:55 ` Liu, Jijiang
2014-08-28 8:36 ` Thomas Monjalon
2014-08-28 11:02 ` Liu, Jijiang
2014-08-28 12:31 ` Thomas Monjalon
2014-08-26 7:31 ` [dpdk-dev] [PATCH v2 4/7]i40e:implement API of VxLAN packet filter in librte_pmd_i40e Jijiang Liu
2014-08-26 7:31 ` [dpdk-dev] [PATCH v2 5/7]]app/testpmd:test VxLAN packet filter API Jijiang Liu
2014-08-26 7:31 ` [dpdk-dev] [PATCH v2 6/7]i40e:support VxLAN Tx checksum offload Jijiang Liu
2014-08-26 7:31 ` [dpdk-dev] [PATCH v2 7/7]app/testpmd:test " Jijiang Liu
2014-08-27 8:17 ` [dpdk-dev] [PATCH v2 0/7]]Support VxLAN on Fortville Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1672259.DZkGQ2cZmA@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).