From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 98C6620F for ; Fri, 15 May 2015 14:55:33 +0200 (CEST) Received: by wicmx19 with SMTP id mx19so38278652wic.0 for ; Fri, 15 May 2015 05:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5KJrNKnmHXJ+Xhlss+EyEbG4OC49FNz18cBT9WASjHc=; b=V+Psvel4wjWIDm6DhtrY28Ph0umok8RnDWr4Nn4gyMtSZeai3XvOCQpaSo6I4BzCeY Kmpy0+w6Z+AQLxDh0SpEkd/MTqXDLUW0Zp68bI7SVaGsEAbolGPc9IyT1g9L8AitFfM+ grCzQRpgNASI2qoZCKqsKCZlKMS/pixw/G+V5HE2DqOd0FZtLPyahQxIDuUrNryZJzCT ceLsx65qEQYD+yvHNJWP4157oLGZZqZyHgDp3ig2x5cePTyLoKcJq8om36/gnGQIfJxt Ddv/IX9103ykwC8ri7fC6KzgOsRB8kWwek9GlukeMENBt2rgjtNGm4CCy9Is4k9Rz7RF iP0A== X-Gm-Message-State: ALoCoQlUsfXmH61RpeTsWbFtQ5JFWsmveXzEIRNePj9pCRgTIsWAm0eUL59N1C2LTDgomuYUJVGS X-Received: by 10.194.143.75 with SMTP id sc11mr17736405wjb.62.1431694533506; Fri, 15 May 2015 05:55:33 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a18sm2349799wja.46.2015.05.15.05.55.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 May 2015 05:55:32 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Fri, 15 May 2015 14:54:50 +0200 Message-ID: <1673093.vQ9JViuheI@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <20150513155831.GA13524@bricha3-MOBL3> References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> <20150513134048.GA13080@bricha3-MOBL3> <20150513155831.GA13524@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 00/19] Move PMDs to drivers directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2015 12:55:33 -0000 2015-05-13 16:58, Bruce Richardson: > On Wed, May 13, 2015 at 02:40:48PM +0100, Bruce Richardson wrote: > > On Wed, May 13, 2015 at 03:33:27PM +0200, Thomas Monjalon wrote: > > > 2015-05-13 11:01, Bruce Richardson: > > > > On Tue, May 12, 2015 at 09:30:45PM +0200, Thomas Monjalon wrote: > > > >> 2015-05-12 19:04, Bruce Richardson: > > > >>> drivers/e1000/e1000/e1000_hw.h | 1026 ++++ > > > >> > > > >> As explained in a previous comment, > > > >> http://dpdk.org/ml/archives/dev/2015-May/017509.html > > > >> I think this path would be better: > > > >> drivers/net/e1000/base/e1000_hw.h > > > > > > > > Two reasons why I didn't create the "net" subfolder: > > > > 1. I initally forgot to consider it :-( > > > > 2. While we may at some future point have other device driver types, are we really > > > > needing to start categorising PMDs at this point? > > > > > > > > As for the base driver part, I was viewing that as a something that should be > > > > a separate patch set, since it's unrelated to moving things to the drivers > > > > subdir. > > > > > > I understand your points and I partially agree. > > > However, file moves may be perturbing because it change habits > > > and may complicate a bit the git history browsing. > > > So I think it's better to minimize such moves and do altogether. > > > > > Ok. I'll see about renaming the base code directories as part of the overall > > move process [Unless there are objections from any of the driver maintainers]. > > > > As for drivers vs drivers/net, I suppose there is no real difference in what > > the path actually is, so I can make that change too. However, I still think I > > prefer the shorter path. Anyone else any opinions on this [before I start > > reworking this again]? > > A further thought on the splitting up of drivers. What about devices which provide > more than one type of offload, how would the PMD for such a device be classified? Other projects (e.g. Linux) would have the same classification problem. How do they solve it? Is it possible to split code in different directories or different drivers?