From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com
 [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 67F371BBE
 for <dev@dpdk.org>; Tue,  7 Mar 2017 17:03:59 +0100 (CET)
Received: by mail-wr0-f179.google.com with SMTP id g10so4643331wrg.2
 for <dev@dpdk.org>; Tue, 07 Mar 2017 08:03:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=r+IJUErCC3OPJsXHIpSkEzDABUIsEvewdlAdidwzopI=;
 b=bDoNBuVHlrHM/HeJwxpVwuoaNJfOnjWZLPoZM0Z39FHkAQUpKUvO+de28R44afQevR
 DRDK3rFJkrlfYxh1MOMTsVw7rP0YKkWlF9ZZESjmVcqiaQB+TPQU2qeeiOpBs8EE31T8
 3uMNj2pFfehpKEEv7jJQ2mwwB8ZkUpi03bOpcBkGeWdf0YZzcr+B7sbgpK9V1T3rl3wh
 8ZBukrAJNTeqfg3WzYCiObUmBPTRxh+45+CXJXoh84b3xF6mOMKMrMvIuXCYOASQ+Olm
 xvLrZFxgmOzW872QGY2FehMeH3ql9wME04IvKmhl/K4snBD6TV9pLSp3j9fRmN2AS3kk
 YLBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=r+IJUErCC3OPJsXHIpSkEzDABUIsEvewdlAdidwzopI=;
 b=plPtT0b6d1Y2M68PcsZrZ/4KeDAkrGcrtdK6+2xAiZl/kUyMubmQ+c7RexMB+y9rVK
 P3UX3TmyI0bskfKxIXff+ThIj1vDajWRgabWd1B9FutNrICiDQaX3gPM38vo6SZyy2C+
 kOaiB9oUL/2vJmN+DGfkcJodZ1HaKKVGiMuv8NQtBioD7fC7V7Bm/cTjz43ItDRrpDAC
 fXchFnorcu+qHaIUg6QshmlQCmfpT8PWU3w/2cqqo+xoCeB3z99WdUn8P/UfeExTZR93
 9c8/fpqYu+oTG7TST29zmOc9wO7D89pDxIjJBsqIj2M2VNEORGBTumTwyml48iLsl8rf
 kkKQ==
X-Gm-Message-State: AMke39nwre7l7cY41vuPNRA16ZexlDMyufA/7m2eJNZys9RqqneStcmHCOeNB5pHu0Jm0w29
X-Received: by 10.223.155.193 with SMTP id e1mr975502wrc.86.1488902638792;
 Tue, 07 Mar 2017 08:03:58 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id c58sm552485wrc.9.2017.03.07.08.03.58
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 07 Mar 2017 08:03:58 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Billy McFall <bmcfall@redhat.com>
Cc: wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org,
 adrien.mazarguil@6wind.com
Date: Tue, 07 Mar 2017 17:03:57 +0100
Message-ID: <1673691.cTdATcOVfP@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <CAKLkqD7D_QhvHCkdQ+QUSyxgjnoBLfZMUROZCvQvn8nTUFH2LQ@mail.gmail.com>
References: <20170123211340.22570-1-bmcfall@redhat.com>
 <2417966.3G0haXHz4n@xps13>
 <CAKLkqD7D_QhvHCkdQ+QUSyxgjnoBLfZMUROZCvQvn8nTUFH2LQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed
	buffers in Tx ring
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Mar 2017 16:03:59 -0000

2017-03-07 09:29, Billy McFall:
> On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> > I think you could use rte_errno (while keeping negative return codes).
> >
> 
> I can do that if you want, but if I understand your comment, it will make
> the implementation of the function not as clean. I cannot use the existing
> RTE_ETH_VALID_PORTID_OR_ERR_RET(..) and RTE_FUNC_PTR_OR_ERR_RET(..) MACROs
> because they are handling the return on error. Or am I missing something?

Yes. Maybe we need new macros for basic error management with rte_errno.