From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] librte_cfgfile (rte_cfgfile.h): modify the macros values
Date: Thu, 03 Sep 2015 16:33:38 +0200 [thread overview]
Message-ID: <1674595.qiqbKFOgvU@xps13> (raw)
In-Reply-To: <1441289888-7035-1-git-send-email-jasvinder.singh@intel.com>
2015-09-03 15:18, Jasvinder Singh:
> This patch refers to the ABI change proposed for librte_cfgfile (rte_cfgfile.h).
> In order to allow for longer names and values, the new values of macros CFG_NAME_LEN and CFG_NAME_VAL are set.
Please wrap the commit message.
CFG_NAME_VAL should be CFG_VALUE_LEN.
The title should start with "cfgfile:".
Instead of talking about macros changes, saying "increase maximum" would give
more clue about the goal of the change.
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ----
> lib/librte_cfgfile/Makefile | 2 +-
> lib/librte_cfgfile/rte_cfgfile.h | 9 +++++++--
> 3 files changed, 8 insertions(+), 7 deletions(-)
You have forgotten to update doc/guides/rel_notes/release_2_2.rst.
next prev parent reply other threads:[~2015-09-03 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1441289108-4501-1-git-send-email-jasvinder.singh@intel.com>
2015-09-03 14:18 ` Jasvinder Singh
2015-09-03 14:33 ` Thomas Monjalon [this message]
2015-09-03 15:46 ` Mcnamara, John
2015-09-03 17:22 ` Thomas Monjalon
2015-09-04 10:58 ` [dpdk-dev] [PATCH v3] librte_cfgfile(rte_cfgfile.h): " Jasvinder Singh
2015-09-07 11:23 ` Dumitrescu, Cristian
2015-10-19 15:54 ` Thomas Monjalon
2015-10-22 14:03 ` [dpdk-dev] [PATCH v4 0/2] cfgfile: " Jasvinder Singh
2015-10-22 14:03 ` [dpdk-dev] [PATCH v4 1/2] qos_sched: fix example modification to use librte_cfgfile Jasvinder Singh
2015-10-22 14:03 ` [dpdk-dev] [PATCH v4 2/2] librte_cfgfile(rte_cfgfile.h): modify the macros values Jasvinder Singh
2015-10-22 16:35 ` [dpdk-dev] [PATCH v4 0/2] cfgfile: " Thomas Monjalon
2015-10-23 8:12 ` Singh, Jasvinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1674595.qiqbKFOgvU@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).