From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 7AD9B3784 for ; Thu, 3 Sep 2015 16:34:48 +0200 (CEST) Received: by wicfx3 with SMTP id fx3so54613260wic.0 for ; Thu, 03 Sep 2015 07:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=PPz5zH0mxB4o7gcqFep2AOHB6gpNIYRBv4A3XrO2icU=; b=UnT0DutE1RebVTJB67pGABaKL9cihOTXXHt+/z9PFPbFykU/uZOzmaIOoizybpfVWF 7EY1U6lRxVvtd/Ui2gYYTby56NA1UEEY4MAAZrsPArA8OTZ/gT/wkI2q7hTs+thWC8oA WjrZQdxeo7LXPb5gCpxEeLRKRCUA17TdqdGA6zTsCSAto88uE2fGEd7zU76hgE7UinPW p8HoNEBn5rZtnpvphaBayrissuq9qEuLWfUwIuV63GJG2VyZAxEz+ySGHDIt2EMyjnqD RMgU6TXthxplg1BSCFp6hq9pSApSxJ8rHnT2b20Hj+PIwk0zSwDSWUWX0sS/vzP87g0k LIbw== X-Gm-Message-State: ALoCoQkBL4kYiwGTTJA9dG0xeuS2K4uFm0iOuCCwmZlvYg/ReXVqFRY6hicQB6zPUdUBK5OpAhNE X-Received: by 10.181.13.36 with SMTP id ev4mr15489079wid.63.1441290888307; Thu, 03 Sep 2015 07:34:48 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ik8sm38117008wjb.8.2015.09.03.07.34.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Sep 2015 07:34:47 -0700 (PDT) From: Thomas Monjalon To: Jasvinder Singh Date: Thu, 03 Sep 2015 16:33:38 +0200 Message-ID: <1674595.qiqbKFOgvU@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1441289888-7035-1-git-send-email-jasvinder.singh@intel.com> References: <1441289108-4501-1-git-send-email-jasvinder.singh@intel.com> <1441289888-7035-1-git-send-email-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] librte_cfgfile (rte_cfgfile.h): modify the macros values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2015 14:34:48 -0000 2015-09-03 15:18, Jasvinder Singh: > This patch refers to the ABI change proposed for librte_cfgfile (rte_cfgfile.h). > In order to allow for longer names and values, the new values of macros CFG_NAME_LEN and CFG_NAME_VAL are set. Please wrap the commit message. CFG_NAME_VAL should be CFG_VALUE_LEN. The title should start with "cfgfile:". Instead of talking about macros changes, saying "increase maximum" would give more clue about the goal of the change. > Signed-off-by: Jasvinder Singh > --- > doc/guides/rel_notes/deprecation.rst | 4 ---- > lib/librte_cfgfile/Makefile | 2 +- > lib/librte_cfgfile/rte_cfgfile.h | 9 +++++++-- > 3 files changed, 8 insertions(+), 7 deletions(-) You have forgotten to update doc/guides/rel_notes/release_2_2.rst.