From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4FBCA0C47; Tue, 12 Oct 2021 11:10:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78E2040151; Tue, 12 Oct 2021 11:10:35 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 0BE724003C for ; Tue, 12 Oct 2021 11:10:33 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 880DC5C01E4; Tue, 12 Oct 2021 05:10:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 12 Oct 2021 05:10:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= EhdYb/xA5HReo/V9n4Y/9tpT3gJwVwFxsfgyl/NUlYw=; b=bzp+9pUs3YkBkQMH 4ZXCHms/tqvDhpISlIaM2ptMNoYEqZXunElhec4UY4tOERPp9NGu294tvK6wI5f1 ESr77VrgQhb/vC/0ZepSc1D2+2CEHTWYi1EjIj5suJYCzyDTEFIcDgAYOpSOXRbR JjEMQlBsyAAtSmBuRBeVQqClsq+rbAUYItwZdZfNoxru1UN/heK4YiwwiFqAPovJ rupb7jBlU5N1P1eiGLxd+8IwCe7hi8LmQogQdeNiwNJAqPD+ju+13vzQa1ay/eG5 ijha0b9vHA6MU6rsTHYhejZq4Sh3b+vdKXUBRStEmBVw37f3QksSwGD2pZWKzmZf MvDrWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EhdYb/xA5HReo/V9n4Y/9tpT3gJwVwFxsfgyl/NUl Yw=; b=SHxjR5b1uq4VVoXR0d/lokeROzOZGwTQFgDra+52LZEl+ngmezbEHx6+7 lZ52jimldEb6KrMxcgg2BGhZXOOUOUisxcXf7fLbKuUYlzmKzH9BuoKjpV7LAsMG S5DdLcoki4k8KjWVnF2EH54iCUO2wBBpAZ2YiePCyg4SjkcEojgwvDG0hjcqg0XZ j+jJCL7dyVWqY4TeiZyQgd9dcxp/FFoYgTwqtUHQRBzrTBPZ71JN4Kch1l0+c2dx UiEnu7BudIZFV8Z2AtACXL2XtYc3Q55YJlTev3kLM50bKJcbuRj0L8ZUVfJ4yiuG /5j+zKpPJR++0Dcu6VIPcJ1QIukHw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtkedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Oct 2021 05:10:30 -0400 (EDT) From: Thomas Monjalon To: "Kundapura, Ganapati" , Ray Kinsella , David Marchand , Jerin Jacob Cc: dpdk-dev , "Jayatheerthan, Jay" Date: Tue, 12 Oct 2021 11:10:27 +0200 Message-ID: <1674729.iRVOSB7e9I@thomas> In-Reply-To: References: <20211007125734.2326512-1-ganapati.kundapura@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/10/2021 10:47, Jerin Jacob: > On Tue, Oct 12, 2021 at 2:05 PM Kundapura, Ganapati > wrote: > > From: Jerin Jacob > > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > > > > @@ -216,6 +216,10 @@ struct rte_event_eth_rx_adapter_stats { > > > > /**< Eventdev enqueue count */ > > > > uint64_t rx_enq_retry; > > > > /**< Eventdev enqueue retry count */ > > > > + uint64_t rx_event_buf_count; > > > > + /**< Rx event buffered count */ > > > > + uint64_t rx_event_buf_size; > > > > > > > > > Isn't ABI breakage? CI did not warn this. Isn't this a public structure? > > Please confirm if moving the above two members to end of the structure overcomes ABI breakage? > > > + @Ray Kinsella @Thomas Monjalon @David Marchand > > It will still break the ABI. IMO, Since it is an ABI breaking release > it is OK. If there are no other objections, Please move the variable > to end > of the structure and update release notes for ABI changes. Why moving since it breaks ABI anyway? I think you can keep as is.