From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
bernard.iremonger@intel.com, tomasz.kantecki@intel.com,
bruce.richardson@intel.com, anatoly.burakov@intel.com,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH 1/3] examples/flow_classify: fix check of port and core
Date: Tue, 20 Apr 2021 03:08:11 +0200 [thread overview]
Message-ID: <1675114.mf6Gbu22uX@thomas> (raw)
In-Reply-To: <1616830818-3127-2-git-send-email-humin29@huawei.com>
27/03/2021 08:40, Min Hu (Connor):
> fix check of port and core in flow_classify example.
>
> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> RTE_ETH_FOREACH_DEV(port)
> - if (rte_eth_dev_socket_id(port) > 0 &&
> + if (rte_eth_dev_socket_id(port) >= 0 &&
> rte_eth_dev_socket_id(port) != (int)rte_socket_id()) {
> printf("\n\n");
> printf("WARNING: port %u is on remote NUMA node\n",
Please explain which case is broken and why.
If I understand well, we don't detect remote NUMA if not running on first socket.
next prev parent reply other threads:[~2021-04-20 1:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:40 [dpdk-dev] [PATCH 0/3] " Min Hu (Connor)
2021-03-27 7:40 ` [dpdk-dev] [PATCH 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-20 1:08 ` Thomas Monjalon [this message]
2021-04-20 2:26 ` Min Hu (Connor)
2021-04-20 9:40 ` Thomas Monjalon
2021-04-27 11:51 ` Iremonger, Bernard
2021-04-27 12:23 ` Min Hu (Connor)
2021-04-27 13:06 ` Iremonger, Bernard
2021-04-28 9:26 ` Iremonger, Bernard
2021-03-27 7:40 ` [dpdk-dev] [PATCH 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-03-27 7:40 ` [dpdk-dev] [PATCH 3/3] examples/skeleton: " Min Hu (Connor)
2021-04-10 9:14 ` [dpdk-dev] [PATCH 0/3] " Min Hu (Connor)
2021-04-19 7:44 ` Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 " Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-28 13:29 ` Iremonger, Bernard
2021-04-29 0:51 ` Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-21 7:00 ` [dpdk-dev] [PATCH v2 3/3] examples/skeleton: " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 0/3] " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 1/3] examples/flow_classify: " Min Hu (Connor)
2021-04-29 9:07 ` Iremonger, Bernard
2021-04-29 9:37 ` Min Hu (Connor)
2021-04-29 11:44 ` Thomas Monjalon
2021-04-29 12:15 ` Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 2/3] examples/l2fwd-cat: " Min Hu (Connor)
2021-04-29 0:50 ` [dpdk-dev] [PATCH v3 3/3] examples/skeleton: " Min Hu (Connor)
2021-05-12 16:52 ` [dpdk-dev] [PATCH v3 0/3] " Ferruh Yigit
2021-05-12 19:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1675114.mf6Gbu22uX@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).