From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 8B6B4C318 for ; Tue, 16 Jun 2015 11:34:23 +0200 (CEST) Received: by wgv5 with SMTP id 5so7862850wgv.1 for ; Tue, 16 Jun 2015 02:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8uIeb4K/KG8/hEdEBDU1fYjQESw1FO+EKUBtVa+In7U=; b=LtaqtwcQvuzRunnIQqDyB2dJedtJxvwoRXwhZyQoVY3vxhws5UbuJIBduTM5eYm0Mp pkAl5ws4XlA0Iupz+WGFHtDql7oMx/50k2mCSCvVjL5RedANB7a+zaexzn2OCg12utWi vrnI8dn+R+wKFr29uEuKywIablgKKPnRN5Pz9cWonlu1WHwcxZXh6imVgxFJaiQUzghz a3vz83DwgIxNlebKxOWcVtrGEnx5RRV2IVC7kR/aRkoYsEVqngZGltENWNJyJXB5vW++ 4CMmTrcXN5LvGL4XArbAA9H9IShXWd8nWMKzT40A+RM200y4E+qDX+OGV8e166SVgttP liAw== X-Gm-Message-State: ALoCoQlLF+A0/6eddNm/Nrra2J73HlRaQXKTs+GtnJnwAW9XZMr5GrbRaYQM7sJz0M5/eiXyf9jI X-Received: by 10.180.187.82 with SMTP id fq18mr4740889wic.47.1434447263389; Tue, 16 Jun 2015 02:34:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id x10sm734374wjf.45.2015.06.16.02.34.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jun 2015 02:34:22 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Tue, 16 Jun 2015 11:33:25 +0200 Message-ID: <1675380.IejOcZZ0JH@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1433949927-14767-9-git-send-email-pablo.de.lara.guarch@intel.com> References: <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com> <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com> <1433949927-14767-9-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 09:34:23 -0000 The following patch is needed and will be squashed to fix some doxygen issues: --- a/lib/librte_hash/rte_jhash.h +++ b/lib/librte_hash/rte_jhash.h @@ -306,13 +306,13 @@ rte_jhash2(const uint32_t *k, uint32_t length, uint32_t initval) * with seeds. If you pass in (*pb)=0, the output (*pc) will be * the same as the return value from rte_jhash. * - * @param k + * @param key * Key to calculate hash of. * @param length * Length of key in bytes. * @param pc * IN: seed OUT: primary hash value. - * @param pc + * @param pb * IN: second seed OUT: secondary hash value. */ static inline void @@ -464,7 +464,7 @@ rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, uint32_t *pb) * Length of key in units of 4 bytes. * @param pc * IN: seed OUT: primary hash value. - * @param pc + * @param pb * IN: second seed OUT: secondary hash value. */ static inline void