DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	david.marchand@redhat.com
Subject: Re: [RFC] eal: support systemd service convention for runtime directory
Date: Wed, 02 Feb 2022 22:03:44 +0100	[thread overview]
Message-ID: <1675633.yIU609i1g2@thomas> (raw)
In-Reply-To: <Ydgs9jQ3pWmokfLk@bricha3-MOBL.ger.corp.intel.com>

07/01/2022 13:07, Bruce Richardson:
> On Thu, Dec 23, 2021 at 03:39:07PM -0800, Stephen Hemminger wrote:
> > Systemd.exec supports configuring the runtime directory of a service
> > via RuntimeDirectory=. This creates the directory with the necessary
> > permissions which actual service may not have if running in container.
> > 
> > The change to DPDK is to look for the environment RUNTIME_DIRECTORY
> > first and use that in preference to the fallback alternatives.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  lib/eal/linux/eal.c | 23 ++++++++++++-----------
> >  1 file changed, 12 insertions(+), 11 deletions(-)
> > 
> Seems reasonable. The path lookup for telemetry in the dpdk-telemetry.py
> script will need updating to match this.

Any followup?
Do you plan a v2 to address comments from Morten and Bruce?




  reply	other threads:[~2022-02-02 21:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23 23:39 Stephen Hemminger
2021-12-26 12:20 ` Morten Brørup
2022-01-05 18:01   ` [RFC] eal: remove size for eal_set_runtime_dir Stephen Hemminger
2022-01-05 20:04     ` Morten Brørup
2022-01-07 12:07 ` [RFC] eal: support systemd service convention for runtime directory Bruce Richardson
2022-02-02 21:03   ` Thomas Monjalon [this message]
2022-02-02 21:07     ` Stephen Hemminger
2022-02-03  6:00 ` [PATCH 0/2] better support of configuring " Stephen Hemminger
2022-02-03  6:00   ` [PATCH 1/2] eal: remove size for eal_set_runtime_dir Stephen Hemminger
2022-02-03  6:00   ` [PATCH 2/2] eal: support systemd service convention for runtime directory Stephen Hemminger
2022-02-03 11:37     ` Bruce Richardson
2022-02-05 17:10   ` [PATCH v2 0/2] eal: support configuring " Stephen Hemminger
2022-02-05 17:11     ` [PATCH v2 1/2] eal: remove size for eal_set_runtime_dir Stephen Hemminger
2022-02-05 17:11     ` [PATCH v2 2/2] eal: support systemd service convention for runtime directory Stephen Hemminger
2022-02-08  4:43     ` [PATCH v2 0/2] eal: support configuring " Stephen Hemminger
2022-02-08 10:48       ` Bruce Richardson
2022-02-09  6:54 ` [PATCH v3 0/3] " Stephen Hemminger
2022-02-09  6:54   ` [PATCH v3 1/3] eal: remove size for eal_set_runtime_dir Stephen Hemminger
2022-02-09  6:54   ` [PATCH v3 2/3] eal: support systemd service convention for runtime directory Stephen Hemminger
2022-02-09  6:54   ` [PATCH v3 3/3] eal: move common filesystem setup code into one file Stephen Hemminger
2022-02-09  9:18     ` Bruce Richardson
2022-02-09 18:14   ` [PATCH v3 0/3] eal: support configuring runtime directory Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1675633.yIU609i1g2@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).