From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D17391B304 for ; Fri, 19 Jan 2018 00:43:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8589A20BB3; Thu, 18 Jan 2018 18:43:43 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 18 Jan 2018 18:43:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+Vf0G/n2Wu7dd+oGCkK9IyIxU0 fFHw61Zaf5FM8gEZo=; b=q4eV8bQ14gT0fexvL0Ua/DsgvENvqkbH5/EV1BdVl3 Eu0lVBMImTf0qCUQRzvO1Hp6hYHhi6pZw09cJdaoQau48OxbEVHn8r3wwEXXl0Uk fGh5OCIzPEyjvHYgC/gyDUj7HJjGZ7l/W4U00JaJjSx3T2Ip0YJxZOrhRPLLMjrw U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+Vf0G/ n2Wu7dd+oGCkK9IyIxU0fFHw61Zaf5FM8gEZo=; b=DQAoIFO1SZqMjVTUa6zNH3 N/QHKYdFXcl1c/5IXnG1NBKoBjiEIT7ipQ+LzX2Iq8ENcvQOgPCFqfmW1lJLS7bD CrtRI/qRQwQhklKljzd5T73NHcZSOHpEwSNIVXus6/9YIzuUKW31I4+LlyTB0wEI 8AypWCisgkCtseD/my0YCDcFPLwNI6MaaY5dvbPr0wmpNrCbCrXWDxAcdVPVDv7M HCT1g2hciGWxTCmtYRdpIUbaI17dEQ0vflMietyKclfRu9CdyeszFRt88WXepBhV qYmYhCPdWiLb8g3jyZVq8v4/SVFm4LnqVXXUSpKY/sOa83xa4sSrKYhxog7lz0kA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 37A3B7E1BE; Thu, 18 Jan 2018 18:43:43 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Elza Mathew Cc: dev@dpdk.org, jasvinder.singh@intel.com Date: Fri, 19 Jan 2018 00:43:09 +0100 Message-ID: <1676244.CyDjruyMnT@xps> In-Reply-To: <20171211153116.GA12544@bricha3-MOBL3.ger.corp.intel.com> References: <1509991543-26521-1-git-send-email-elza.mathew@intel.com> <20171211153116.GA12544@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] net: run-time function selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 23:43:44 -0000 11/12/2017 16:31, Bruce Richardson: > On Mon, Nov 06, 2017 at 10:05:43AM -0800, Elza Mathew wrote: > > Compile-time function selection can potentially lead to > > lower performance on generic builds done by distros. > > Replaced compile time flag checks with run-time > > function selection. > > > > Signed-off-by: Elza Mathew > > --- > > lib/librte_net/rte_net_crc.c | 22 +++++++++++++--------- > > 1 file changed, 13 insertions(+), 9 deletions(-) > > > Patch looks good to me, but unfortunately the compilation testing shows > an issue with clang compliation on FreeBSD 10. I've also tested with gcc > on both BSD 10 and 11 and saw no issues, and BSD 11 clang compilation is > also fine. > > The compilation error is due to missing _mm_clmulepi64_si128 instrinsic: > In file included from /home/patchWorkOrg/compilation/lib/librte_net/rte_net_crc.c:43: > /home/patchWorkOrg/compilation/lib/librte_net/net_crc_sse.h:81:17: error: implicit declaration of function '_mm_clmulepi64_si128' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > __m128i tmp0 = _mm_clmulepi64_si128(fold, precomp, 0x01); Any update please?