From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EA37A0A0E; Tue, 11 May 2021 15:20:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 205C940140; Tue, 11 May 2021 15:20:46 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A75804003E for ; Tue, 11 May 2021 15:20:44 +0200 (CEST) IronPort-SDR: V8dN2JuCbbqwh9OXyzgTKLq6n84VtMIPqoNSf8abfDLAQrNWi3ArSzR99EVUiPwhKzxw5q8V40 iXC6XsbdTfsA== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="197458098" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="197458098" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 06:20:38 -0700 IronPort-SDR: /DayLewQxX6ExM3paAfuPA30qJR2erosWGiiu0iPNQEr4INQcTRqZgRYSw+t/6Jlmpvxsjpp1h tT4Uy9E+Qdeg== X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="537024344" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.45]) ([10.213.224.45]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 06:20:36 -0700 To: "Dumitrescu, Cristian" , Haifei Luo , "matan@nvidia.com" , "orika@nvidia.com" , "viacheslavo@nvidia.com" , "Li, Xiaoyun" Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "rasland@nvidia.com" , "Singh, Jasvinder" References: <20210428141015.25728-1-haifeil@nvidia.com> <20210511092810.22801-1-haifeil@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <167700ab-cfdf-b03a-aab2-857f873781f5@intel.com> Date: Tue, 11 May 2021 14:20:32 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/11/2021 1:34 PM, Dumitrescu, Cristian wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, May 11, 2021 12:35 PM >> To: Haifei Luo ; matan@nvidia.com; orika@nvidia.com; >> viacheslavo@nvidia.com; Li, Xiaoyun >> Cc: dev@dpdk.org; thomas@monjalon.net; rasland@nvidia.com; Singh, >> Jasvinder ; Dumitrescu, Cristian >> >> Subject: Re: [PATCH v2] app/testpmd: add CLI for action meter color >> >> On 5/11/2021 10:28 AM, Haifei Luo wrote: >>> Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined. >>> Add the CLI for this action in meter policy: color type (types) >>> There are three types: green, yellow and red. >>> >>> Example for the new policy meter CLIs: >>> add port meter policy 0 1 g_actions color type green / end y_actions >>> color type yellow / end r_actions color type red / end >>> >>> In the above command, the action type is >> RTE_FLOW_ACTION_TYPE_METER_COLOR, >>> the meter policy action list: green -> green, yellow -> yellow, red -> red. >>> >>> V2: rebase the latest code. >>> >>> Signed-off-by: Haifei Luo >>> Acked-by: Ori Kam >> >> >> cc'ed Jasvinder & Cristian for review. >> >> This patch is not a fix but adding support for testing new meter action type, >> so >> I assume it can be postponed to next release if missing review from >> maintainers. > > Hi Ferruh, > > This patch looks good to me, but I think it should be reviewed and acked by Xiaoyun, the testpmd maintainer, who is already in the To: list? > If so I will proceed with your explicit ack: Cristian Dumitrescu Xiaoyun is main maintainer but for some submodules we rely on the relevant maintainer, like flow API related part to Ori or for meter/tm part to you etc..