DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD
Date: Tue, 25 Aug 2015 14:36:59 +0200	[thread overview]
Message-ID: <1677849.ZVAMZEjUYk@xps13> (raw)
In-Reply-To: <1439913312-14761-1-git-send-email-ian.stokes@intel.com>

2015-08-18 16:55, Ian Stokes:
> The qos_meter sample app will fail to compile if APP_MODE
> is set to APP_MODE_FWD. This patch changes the variable
> name 'color' in main.h to the expected variable name
> 'input_color' to allow compilation with APP_MODE_FWD.

Thanks for raising the issue.

> --- a/examples/qos_meter/main.h
> +++ b/examples/qos_meter/main.h
>  #if APP_MODE == APP_MODE_FWD
>  
> -#define FUNC_METER(a,b,c,d) color, flow_id=flow_id, pkt_len=pkt_len, time=time
> +#define FUNC_METER(a,b,c,d) input_color, flow_id=flow_id, pkt_len=pkt_len, time=time

This patch should not be accepted to discourage build-time options.
Patch for run-time option is welcome.

  parent reply	other threads:[~2015-08-25 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 15:55 Ian Stokes
2015-08-18 22:36 ` Mcnamara, John
2015-08-25 12:36 ` Thomas Monjalon [this message]
2015-08-25 13:34   ` Mcnamara, John
2015-08-25 13:42     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1677849.ZVAMZEjUYk@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).