From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A41B841E6D;
Fri, 10 Mar 2023 23:16:18 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B4E1042D16;
Fri, 10 Mar 2023 23:15:44 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 0EC7E40A8B
for <dev@dpdk.org>; Fri, 10 Mar 2023 23:15:37 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id DEAA92044734; Fri, 10 Mar 2023 14:15:35 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DEAA92044734
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1678486535;
bh=NGeD/kktCtxHao+11pGy3/7JGaXKOT/dp1Jpsw1eEbI=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=QYSmt362cdWWwSWRa4mmupFm8/cfa3xgqW09YaLbIbrmuEFVLdeW0aeTBI24sA/aT
fPfToT1Y6BXr2jkloZpCX3gei2PJFQ3Y190SE8cqVHLeUTXsTksocZCzWWSCpzMjAH
sDFS7QEIKLlnzpmfAmr+SeSCDWTmhhNdT4ZRmT/E=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH 08/16] net/iavf: use previous value atomic fetch operations
Date: Fri, 10 Mar 2023 14:15:22 -0800
Message-Id: <1678486530-20688-9-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>
References: <1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Use __atomic_fetch_{add,and,or,sub,xor} instead of
__atomic_{add,and,or,sub,xor}_fetch adding the necessary code to
allow consumption of the resulting value.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
drivers/net/iavf/iavf_vchnl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 9adaadb..51d4fc7 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -120,7 +120,7 @@ struct iavf_event_handler {
{
struct iavf_event_handler *handler = &event_handler;
- if (__atomic_add_fetch(&handler->ndev, 1, __ATOMIC_RELAXED) != 1)
+ if (__atomic_fetch_add(&handler->ndev, 1, __ATOMIC_RELAXED) + 1 != 1)
return 0;
#if defined(RTE_EXEC_ENV_IS_WINDOWS) && RTE_EXEC_ENV_IS_WINDOWS != 0
int err = _pipe(handler->fd, MAX_EVENT_PENDING, O_BINARY);
@@ -149,7 +149,7 @@ struct iavf_event_handler {
{
struct iavf_event_handler *handler = &event_handler;
- if (__atomic_sub_fetch(&handler->ndev, 1, __ATOMIC_RELAXED) != 0)
+ if (__atomic_fetch_sub(&handler->ndev, 1, __ATOMIC_RELAXED) - 1 != 0)
return;
int unused = pthread_cancel(handler->tid);
@@ -533,8 +533,8 @@ struct iavf_event_handler {
/* read message and it's expected one */
if (msg_opc == vf->pend_cmd) {
uint32_t cmd_count =
- __atomic_sub_fetch(&vf->pend_cmd_count,
- 1, __ATOMIC_RELAXED);
+ __atomic_fetch_sub(&vf->pend_cmd_count,
+ 1, __ATOMIC_RELAXED) - 1;
if (cmd_count == 0)
_notify_cmd(vf, msg_ret);
} else {
--
1.8.3.1