From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>,
Pawel Wodkowski <pawelx.wodkowski@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/2] bond: add mode 4 support
Date: Mon, 24 Nov 2014 19:05:32 +0100 [thread overview]
Message-ID: <1679332.pWPR9Gg93t@xps13> (raw)
In-Reply-To: <1416849181-17183-2-git-send-email-michalx.k.jastrzebski@intel.com>
2014-11-24 17:13, Michal Jastrzebski:
> From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
>
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
As I've already requested, we need some explanations.
The minimum is to explain what is mode 4 or give inputs.
It won't be integrated without it. Wednesday is the deadline for this stuff.
> ---
> lib/librte_ether/rte_ether.h | 1 +
> lib/librte_pmd_bond/Makefile | 2 +
> lib/librte_pmd_bond/rte_eth_bond.h | 5 +
> lib/librte_pmd_bond/rte_eth_bond_8023ad.c | 1218 +++++++++++++++++++++
> lib/librte_pmd_bond/rte_eth_bond_8023ad.h | 214 ++++
> lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h | 308 ++++++
> lib/librte_pmd_bond/rte_eth_bond_api.c | 91 +-
> lib/librte_pmd_bond/rte_eth_bond_args.c | 1 +
> lib/librte_pmd_bond/rte_eth_bond_pmd.c | 262 ++++-
> lib/librte_pmd_bond/rte_eth_bond_private.h | 31 +-
For a such big development, there are probably some interesting things to
explain about design, performance, etc.
Be proud of your work!
--
Thomas
next prev parent reply other threads:[~2014-11-24 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 17:12 [dpdk-dev] [PATCH v5 0/2] bond: " Michal Jastrzebski
2014-11-24 17:13 ` [dpdk-dev] [PATCH v5 1/2] bond: add " Michal Jastrzebski
2014-11-24 18:05 ` Thomas Monjalon [this message]
2014-11-24 17:13 ` [dpdk-dev] [PATCH v5 2/2] testpmd: " Michal Jastrzebski
2014-11-25 9:45 ` [dpdk-dev] [PATCH v5 0/2] bond: " Wodkowski, PawelX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1679332.pWPR9Gg93t@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michalx.k.jastrzebski@intel.com \
--cc=pawelx.wodkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).