From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id AAD1F9E3 for ; Fri, 28 Apr 2017 10:15:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4B79E2084A; Fri, 28 Apr 2017 04:15:48 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 28 Apr 2017 04:15:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=afc5oeenFhDCiSF XyiUC0VJbC2mWEQuR2T1U9vuNDGA=; b=bYUt8WYogpoP4lmxKf6q0Ad4Zr2PbLx tI04lM2MLIiQmm0RJ993XtrPrLngrG0sDYV/Y/i9qHGEQ2oChsi97MUAu918BEZi hP0e+hxsXNYO5qReAy/F9YDd0CVJ1hNtKxdKe1VeWqPM0nbVbUSC1c+X7UNy0pFI B/s9l7NXEJO0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=afc5oeenFhDCiSFXyiUC0VJbC2mWEQuR2T1U9vuNDGA=; b=VuH3mV3b tkKPiDS8PjVDml+ANaLprYLnXl01xLIdasynL9FRVirW9zXCYpNhJnTqGGnlL5zq foPFJIoyeFf69Okn0LuZo/bCu5Ox30/9YMuzPZG2GU/Uc1w2tgo2nuK4BYMTVao8 4uBvpSnQ83EI9N71prFXgV9NXxCbDdi2PheYr6ac9gXxkPIT2lXSmJz6KWvD25HL g4miZfCVPg6m/SiNjYIs/NSl6H/jwfsXylgpdv7AuMSPEj821FieCw6cw7gL3IcE TlhcDhNwXJ1M1Wr0FEDzKC7AkZYVGTuufrEItI7lt02Gd5mrr4CfzdMph9GiKezW ChjyJ6lbXhYbEw== X-ME-Sender: X-Sasl-enc: wlJMeB6Dp7CVgmoo8SVS9QJYQwOhKTXom/g3uU2ssQHW 1493367347 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5D447E88D; Fri, 28 Apr 2017 04:15:47 -0400 (EDT) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org Date: Fri, 28 Apr 2017 10:15:46 +0200 Message-ID: <1679460.mJD8jeqIBn@xps> In-Reply-To: <1493364114-7771-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1493364114-7771-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 08:15:49 -0000 28/04/2017 09:21, Yuanhan Liu: > Some commits for stable releases (with Cc stable tag) may not have the > fixline. For example: > http://dpdk.org/dev/patchwork/patch/23955/ > > It disables a feature we have implemented in last release. The feature > is done right. It's the QEMU implementaton being buggy, that we have to > disable it to workaround those buggy QEMU releases (v2.7 - v2.9). Without > such workaround, QEMU won't start when queue number >= 2. > > That said, we also have to backport it to stable releases, though there > is no fixline (there was no DPDK bug to fix after all). How do we know where should it be backported? It is fixing a bug with a correct implementation because of a buggy dependency. But it is still a bug. So I think we should put a Fixes: line. > > There should be similar cases like this. Thus, this patch makes > git-log-fixes.sh script also list those stable commits do not have > fixline. I am against putting Cc: stable without Fixes: line. However, this patch is harmless.