From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0CCEF7D4F for ; Wed, 23 Aug 2017 09:51:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9F9E620C6B; Wed, 23 Aug 2017 03:51:46 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 23 Aug 2017 03:51:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=XwnbKu9Bk3N8/pv n6fx1bcNUvL00ir46Cr5ZmE45wzc=; b=ji94fsiIIm/F55SeMqxaFPW4vyj9+SJ Q1v6fqwzbZ5cNHeixXy/U+bhyBU/mb8Ho47YXk/Eqk078hDysoZslxRLPk3MRm50 hl4RnOoDr8vc9/Lpnz2TqwHDhL7kXl8NPXlv9ArQTdlC+kXuek7Br/e7JHOD7eDd kXyl2X6E/MbY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=XwnbKu9Bk3N8/pvn6fx1bcNUvL00ir46Cr5ZmE45wzc=; b=ZhX5S3hl YKDrhwCQCOF63VBrivMsBT8D+3K9/c+khTjN9DmSppn+QPkZMV7vExgbRDnvDrQM 0UZktvaVLK6x1uZgE4VRkv9aiRbKW35WerJ6EPZi5M34FD2eZWd2foTA1eNYenUF zeq0UF8Y9v8oV5KsTaA7Wtpjk8AHERT404AluZfvzNdFYI02fEJl+LwH+ULLysg6 SJK5UdFYibpI1DlRTK0UaNozog4DJEdS/Iaj9YVBngIgUwSAL8hTLMAqJi/JCJTa 3UMn0kSrGDO6Tytbv+NLkw4zwF6QS21n+lffBLDoccjMWiUEhn+pYIRGuKzfM8qw 4p7um7+RtTjbjw== X-ME-Sender: X-Sasl-enc: Gsi79ffyoqjN90WljTMS7xKNpEe9HspuSzpVrUq+4EIF 1503474706 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 483E97E1B4; Wed, 23 Aug 2017 03:51:46 -0400 (EDT) From: Thomas Monjalon To: David Harton Cc: dev@dpdk.org Date: Wed, 23 Aug 2017 09:51:45 +0200 Message-ID: <1679481.0OI12NtS3X@xps> In-Reply-To: <20170823025555.19022-1-dharton@cisco.com> References: <20170823011937.37579-1-dharton@cisco.com> <20170823025555.19022-1-dharton@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 07:51:48 -0000 23/08/2017 04:55, David Harton: > rte_eth_stats_get() unconditonally would set rx_nombuf > even if the device was setting the value. A check has > been added in rte_eth_stats_get() to leave the device > value in-tact when non-zero. If we get this counter from stats->rx_nombuf, why keeping dev->data->rx_mbuf_alloc_failed ? We could rework other PMDs to not use this global variable. It is inconsistent to use it for some PMDs but not all. And it seems not used outside of PMDs.