From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2DD2C42829;
Thu, 23 Mar 2023 23:54:31 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C5C2442D13;
Thu, 23 Mar 2023 23:54:07 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id A1B4440689
for <dev@dpdk.org>; Thu, 23 Mar 2023 23:54:00 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id 73C1820E99CB; Thu, 23 Mar 2023 15:53:59 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 73C1820E99CB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1679612039;
bh=J7i4DqZbDv5sne8urNPPLLcaOyNSlZIsnoYHc5HJ2jI=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=P+zMQBLfzfHP1OAohZrXDolFGotuPs6mvvpkEeall5wQ4sqSaV9PTuBvpPgD2xotd
tDwWepqM/i2ETdB2EbcS04cuKmMjmJ/83Z6dSqwOBoa95iEh6yQnBKS8aisrx1tal0
O3KlIPbOzLR5hgE/uig9cGPT+26QfA59jGHlxgc4=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,
stephen@networkplumber.org, mb@smartsharesystems.com,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v3 6/7] net/null: replace rte atomics with GCC builtin atomics
Date: Thu, 23 Mar 2023 15:53:55 -0700
Message-Id: <1679612036-30773-7-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1679612036-30773-1-git-send-email-roretzla@linux.microsoft.com>
References: <1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com>
<1679612036-30773-1-git-send-email-roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Replace the use of rte_atomic.h types and functions, instead use GCC
supplied C++11 memory model builtins.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
drivers/net/null/rte_eth_null.c | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 47d9554..31081af 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -37,8 +37,8 @@ struct null_queue {
struct rte_mempool *mb_pool;
struct rte_mbuf *dummy_packet;
- rte_atomic64_t rx_pkts;
- rte_atomic64_t tx_pkts;
+ uint64_t rx_pkts;
+ uint64_t tx_pkts;
};
struct pmd_options {
@@ -101,7 +101,8 @@ struct pmd_internals {
bufs[i]->port = h->internals->port_id;
}
- rte_atomic64_add(&(h->rx_pkts), i);
+ /* NOTE: review for potential ordering optimization */
+ __atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);
return i;
}
@@ -128,7 +129,8 @@ struct pmd_internals {
bufs[i]->port = h->internals->port_id;
}
- rte_atomic64_add(&(h->rx_pkts), i);
+ /* NOTE: review for potential ordering optimization */
+ __atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);
return i;
}
@@ -152,7 +154,8 @@ struct pmd_internals {
for (i = 0; i < nb_bufs; i++)
rte_pktmbuf_free(bufs[i]);
- rte_atomic64_add(&(h->tx_pkts), i);
+ /* NOTE: review for potential ordering optimization */
+ __atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);
return i;
}
@@ -174,7 +177,8 @@ struct pmd_internals {
rte_pktmbuf_free(bufs[i]);
}
- rte_atomic64_add(&(h->tx_pkts), i);
+ /* NOTE: review for potential ordering optimization */
+ __atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);
return i;
}
@@ -316,8 +320,9 @@ struct pmd_internals {
RTE_MIN(dev->data->nb_rx_queues,
RTE_DIM(internal->rx_null_queues)));
for (i = 0; i < num_stats; i++) {
+ /* NOTE: review for atomic access */
igb_stats->q_ipackets[i] =
- internal->rx_null_queues[i].rx_pkts.cnt;
+ internal->rx_null_queues[i].rx_pkts;
rx_total += igb_stats->q_ipackets[i];
}
@@ -325,8 +330,9 @@ struct pmd_internals {
RTE_MIN(dev->data->nb_tx_queues,
RTE_DIM(internal->tx_null_queues)));
for (i = 0; i < num_stats; i++) {
+ /* NOTE: review for atomic access */
igb_stats->q_opackets[i] =
- internal->tx_null_queues[i].tx_pkts.cnt;
+ internal->tx_null_queues[i].tx_pkts;
tx_total += igb_stats->q_opackets[i];
}
@@ -347,9 +353,11 @@ struct pmd_internals {
internal = dev->data->dev_private;
for (i = 0; i < RTE_DIM(internal->rx_null_queues); i++)
- internal->rx_null_queues[i].rx_pkts.cnt = 0;
+ /* NOTE: review for atomic access */
+ internal->rx_null_queues[i].rx_pkts = 0;
for (i = 0; i < RTE_DIM(internal->tx_null_queues); i++)
- internal->tx_null_queues[i].tx_pkts.cnt = 0;
+ /* NOTE: review for atomic access */
+ internal->tx_null_queues[i].tx_pkts = 0;
return 0;
}
--
1.8.3.1