From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f178.google.com (mail-wj0-f178.google.com [209.85.210.178]) by dpdk.org (Postfix) with ESMTP id F1C8B10D19 for ; Thu, 22 Dec 2016 12:18:28 +0100 (CET) Received: by mail-wj0-f178.google.com with SMTP id ez4so7637174wjd.0 for ; Thu, 22 Dec 2016 03:18:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=b2sEAY/svnFRQx6RMzjh4x7E5DkOSzkwlf18azp1QZg=; b=XEUBrAmeq2HGrjy2Gbt8UYYpanoA879hBPKyWnxxF0xzb3kROwcUPNFDlrDtgg25v7 +hkwRCbJczYc7IDubZ3mfrg2p1wljbG1RF44AqhcQBc5xdIN7F83gPzJ77AuwzEQ7t+e 95YsxR1AT6FaaKDZCRT4yo/HN/Gjh++PTXtZKOm4LPJdjn1fPonsEu5Zx+zDKx+kN/GE +GbWHsnRQglhYXQ5m6y17SeliNn6/hLWXr5AgpD4/AVI8PWdYRbC6fvHZnHJs+3RvoNf zFzh1QLfwPKaCs78Yf/jY1L7ASouQVf5deekjURnvAN6WtbAPITSEpX1oj1B4/pIWSMs j6pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=b2sEAY/svnFRQx6RMzjh4x7E5DkOSzkwlf18azp1QZg=; b=uJTzPesiqP201Wr1WWazZE+sDn/49X4gOSExlQANbI6J3tv0Y7HL70wJi2cNGmzzUQ yvU6uVhzO8fEYbbwX619N2rzpQ2DhrxZMtI3o1MIcUbEETnr5f1Ien32N8IJfbtJzjJ8 5hPlldWQ3qCgSmVvl7mX1+lmw8GFYXkxgPzYj9PDw7K5zr0BC/ROXuWQixz0TV7lel68 KjfFOIMOsen+KsLhaSa6hroA7rbl3qDNARmY0iyF13Tnh06dI18dWO4ssS9ljowxgJgS cw00o4UXKcue19SZIrzDV2dcFSswjg/Npnybj3RZKKfvVuKJ9Oglxf0NMPxF062fUWZb RyLw== X-Gm-Message-State: AIkVDXIR8svzswxllrimI+sPzEdPnagNdEP+cPfw9HnvdnAzLdLdxbWWbpp8dLGW9uF2QfkJ X-Received: by 10.194.0.43 with SMTP id 11mr8707814wjb.218.1482405508689; Thu, 22 Dec 2016 03:18:28 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l6sm31731890wmd.5.2016.12.22.03.18.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 03:18:28 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Thu, 22 Dec 2016 12:18:27 +0100 Message-ID: <1679817.BkgAe1E4Dq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161208135940.17233-1-ferruh.yigit@intel.com> References: <20161208135940.17233-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: cleanup device ops struct whitespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 11:18:29 -0000 2016-12-08 13:59, Ferruh Yigit: > - Grouped related items using empty lines I have few comments below. [...] > + > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > - /**< Get packet types supported and identified by device*/ > - mtu_set_t mtu_set; /**< Set MTU. */ > - vlan_filter_set_t vlan_filter_set; /**< Filter VLAN Setup. */ > - vlan_tpid_set_t vlan_tpid_set; /**< Outer/Inner VLAN TPID Setup. */ > + /**< Get packet types supported and identified by device. */ We could add a blank line here. > + mtu_set_t mtu_set; /**< Set MTU. */ > + [...] > + > + eth_udp_tunnel_port_add_t udp_tunnel_port_add; /** Add UDP tunnel port. */ > + eth_udp_tunnel_port_del_t udp_tunnel_port_del; /** Del UDP tunnel port. */ > + [...] > + > + reta_update_t reta_update; /** Update redirection table. */ > + reta_query_t reta_query; /** Query redirection table. */ > + > + eth_get_reg_t get_reg; /**< Get registers. */ > + eth_get_eeprom_length_t get_eeprom_length; /**< Get eeprom length. */ > + eth_get_eeprom_t get_eeprom; /**< Get eeprom data. */ > + eth_set_eeprom_t set_eeprom; /**< Set eeprom. */ > + [...] > + rss_hash_update_t rss_hash_update; /** Configure RSS hash protocols. */ > + rss_hash_conf_get_t rss_hash_conf_get; /** Get current RSS hash configuration. */ RSS should go above with RETA. > + eth_filter_ctrl_t filter_ctrl; /**< common filter control. */ > + eth_set_mc_addr_list_t set_mc_addr_list; /**< set list of mcast addrs. */ Should go with other MAC functions. [...] > + eth_timesync_enable_t timesync_enable; > /** Turn IEEE1588/802.1AS timestamping on. */ > - eth_timesync_enable_t timesync_enable; > + eth_timesync_disable_t timesync_disable; > /** Turn IEEE1588/802.1AS timestamping off. */ > - eth_timesync_disable_t timesync_disable; > - /** Read the IEEE1588/802.1AS RX timestamp. */ > eth_timesync_read_rx_timestamp_t timesync_read_rx_timestamp; > - /** Read the IEEE1588/802.1AS TX timestamp. */ > + /** Read the IEEE1588/802.1AS RX timestamp. */ > eth_timesync_read_tx_timestamp_t timesync_read_tx_timestamp; > + /** Read the IEEE1588/802.1AS TX timestamp. */ > + > + eth_get_dcb_info get_dcb_info; /** Get DCB information. */ DCB should not be in the middle of timesync functions. > + eth_timesync_adjust_time timesync_adjust_time; /** Adjust the device clock. */ > + eth_timesync_read_time timesync_read_time; /** Get the device clock time. */ > + eth_timesync_write_time timesync_write_time; /** Set the device clock time. */