From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A0A9A0524; Thu, 30 Jan 2020 11:56:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 915A31BFFA; Thu, 30 Jan 2020 11:56:39 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 595191BFE6; Thu, 30 Jan 2020 11:56:38 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id z7so3397808wrl.13; Thu, 30 Jan 2020 02:56:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=a8HoGfLXzjdyFSeTrca1nBGYjeFsiFVmRQ0JbuZASIg=; b=OhCl29o1A2a/UqXYBB+0VcbMMDz7TaTysP59xmb7xm77nD0ycGtEgueFfFFJgnd+/T BNq+PbRmFHw2K6ABr56x4XNdojR2UA1xVNESxY+wSiP0nmRohLcy+iSKKGq8Zh8801RJ N2G+FeWdH/gvjsFVdnWgRuO+W8RRx9FYYjr6+cwE67geTQAzr0sCDx02UZ+lfE14RAmX 7lAQ2g5k3iLIAWNWqfNbFq5uYDF5vsmRtTwGHTR8N6VvF3I0IHO1qTCE4306aOyYZCJP OK5YCpc0lBsjcd/0j6ug/lAeYXiFOSWzNVKXAFCaKADU79tNNlS8I6U9IDAwU2hU9t7a 3FwQ== X-Gm-Message-State: APjAAAWa4UAlZAubdGuPSK1yylF7BtMHzG99Tn1A+8sHgMVcqdZH7eHu oQfQ8YfSlyPntwoMsyzvErB15FDTphQ= X-Google-Smtp-Source: APXvYqyRtXnEKtj3GVzLS0n+3Md8BuK0yaA6fxdT+cvhjJvUURDwcMly2jA0CpI4ecovcDRifjmqZA== X-Received: by 2002:a5d:6ac3:: with SMTP id u3mr5081446wrw.25.1580381797949; Thu, 30 Jan 2020 02:56:37 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 16sm6031102wmi.0.2020.01.30.02.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2020 02:56:37 -0800 (PST) Message-ID: <167b2eafc1cff4aef40eea97d24819c4f0254ab3.camel@debian.org> From: Luca Boccassi To: David Marchand Cc: dev , Thomas Monjalon , Bruce Richardson , Kevin Laatz , Aaron Conole , Neil Horman , Akhil Goyal , Anoob Joseph , dpdk stable , Yipeng Wang , Sameh Gobriel , Harry van Haaren , Keith Wiles Date: Thu, 30 Jan 2020 10:56:36 +0000 In-Reply-To: References: <20191220152058.10739-1-david.marchand@redhat.com> <20200129172621.28565-1-david.marchand@redhat.com> <20200129172621.28565-2-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] hash: fix meson headers packaging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-01-30 at 11:54 +0100, David Marchand wrote: > On Thu, Jan 30, 2020 at 11:12 AM Luca Boccassi < > bluca@debian.org > > wrote: > > On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote: > > > Those headers are internal and should not be distributed. > > >=20 > > > Fixes: 5b9656b157d3 ("lib: build with meson") > > > Cc: > > > stable@dpdk.org > > >=20 > > >=20 > > >=20 > > > Signed-off-by: David Marchand < > > > david.marchand@redhat.com > > >=20 > > >=20 > > > --- > > > lib/librte_hash/meson.build | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > >=20 > > > diff --git a/lib/librte_hash/meson.build > > > b/lib/librte_hash/meson.build > > > index 5d02b3084..bce11ad9e 100644 > > > --- a/lib/librte_hash/meson.build > > > +++ b/lib/librte_hash/meson.build > > > @@ -1,10 +1,7 @@ > > > # SPDX-License-Identifier: BSD-3-Clause > > > # Copyright(c) 2017 Intel Corporation > > >=20 > > > -headers =3D files('rte_cmp_arm64.h', > > > - 'rte_cmp_x86.h', > > > - 'rte_crc_arm64.h', > > > - 'rte_cuckoo_hash.h', > > > +headers =3D files('rte_crc_arm64.h', > > > 'rte_fbk_hash.h', > > > 'rte_hash_crc.h', > > > 'rte_hash.h', > >=20 > > Difficult question: how confident we are nobody is using those? :-) >=20 > Those headers are for internal structures. > When installing with make, those headers were skipped. >=20 > Grepping on the dpdk projects that I monitor (based on Stephen list): >=20 > $ for header in rte_cmp_arm64.h rte_cmp_x86.h rte_cuckoo_hash.h; do > echo "=3D=3D=3D=3D=3D=3D=3D $header"; git grep-all -l $header; echo; done > =3D=3D=3D=3D=3D=3D=3D rte_cmp_arm64.h > F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build > F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h > Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h > yastack origin/HEAD:dpdk/lib/librte_hash/meson.build > yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h >=20 > =3D=3D=3D=3D=3D=3D=3D rte_cmp_x86.h > F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build > F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h > Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h > yastack origin/HEAD:dpdk/lib/librte_hash/meson.build > yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h >=20 > =3D=3D=3D=3D=3D=3D=3D rte_cuckoo_hash.h > F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build > F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c > F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h > Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.c > Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h > yastack origin/HEAD:dpdk/lib/librte_hash/meson.build > yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c > yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h Great, thanks for checking! --=20 Kind regards, Luca Boccassi