From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA3D8A00C5; Thu, 30 Apr 2020 08:48:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A31751D8CC; Thu, 30 Apr 2020 08:48:53 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B134A1D739 for ; Thu, 30 Apr 2020 08:48:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 252DC5C00E9; Thu, 30 Apr 2020 02:48:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 30 Apr 2020 02:48:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= aJAmtykeIoc8oE1VMq8x+Kl++94/YPRVzUGW0RPh8b8=; b=rIrMuubvTMmjfxyz n/FdJQmIGnKUBzOGxOiTLQV6PwkycGwS0SOL6VPo2s8+TlT+9LAOrUTxY8u24ibP d8MQI27Dll4RiNT76caaAUcmOvisUlyGGm+Y3swxyoZoXT/ZmA+lSrHeBCNTSwKf kjI3g/kvEQuoSWdXR3mJgZnITxGbnbiU+qw1AxAt1+ZjY+GjSce0TuY0L3UED3zy 74x3JPEDZuk7TFNo0Nd9qpH541Dh5fEwRZVRbuO/Mzk+F+9Ee+wD9NZQwDn1tucL zak7NpVyvsDsrmbAtUk57oq9OZ90ElB7Ejfa4OjOJPtHVH0wv+hdD1SiErsymO8k ttJ4Sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aJAmtykeIoc8oE1VMq8x+Kl++94/YPRVzUGW0RPh8 b8=; b=jZHYtsQdlIbbSVEz+7eFDj4YIVXeEOgPEPNhRCHTGteV5rHUK87uSoWGT AvumUQD4ydNYf/FeqX64Me8G4PZruaeC0hJUF5FCMEKA+m+/HE3EXDeZTKUceeKI EBQzxS64X1+MWoWucPn3aJhQZkr6cQ3g32eOLFehVl00jNPzEi8Eselgw+3OGj3i KFqiRh+dae1ipqYih6CxQTxasNbaLiMMGJwr9GoDrZEdpsHiIYtLCzOaWWkO2Jg8 MsOzGO3QE4285PNYNsBtkb5aX/d/M3HZmpdLuGxuq/V/JV+CTaE38ZZK5ptjhHaf U6viL9Ef6tctxjuHwwTZ0QA/fQjUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieeggdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DA0803065EFE; Thu, 30 Apr 2020 02:48:50 -0400 (EDT) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, ranjit.menon@intel.com, Harini.Ramakrishnan@microsoft.com, Narcisa.Vasile@microsoft.com, dmitry.kozliuk@gmail.com, tbashar@mellanox.com Date: Thu, 30 Apr 2020 08:48:49 +0200 Message-ID: <1680001.aGCPj5yezQ@thomas> In-Reply-To: <20200429232427.7112-1-pallavi.kadam@intel.com> References: <20200429232427.7112-1-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/2] Windows logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/04/2020 01:24, Pallavi Kadam: > This patchset adds EAL logging support on Windows. > Logs will be sent to console output. > > Pallavi Kadam (2): > eal: initialize eal logging on Windows > eal: add fnmatch implementation on Windows fnmatch is required to change the log level of logs specified with a globbing pattern. I think it would be nicer to introduce fnmatch first, and state in the other patch that logging is supported on Windows. Titles would be: eal/windows: add fnmatch implementation log: support on Windows