From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id D7E732956 for ; Thu, 7 Apr 2016 19:51:46 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id l6so35595786wml.1 for ; Thu, 07 Apr 2016 10:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=kXOe724pI0nHKRZtSp++/O6E9r+hPQD982QjTdbSIH8=; b=uSeF9t8nfx6lrdaHPIOJBZm4e40YCKZWl0OzbeewKvK0p7LXm7N/53CYPILa384C2R E2TbGAkkJSTJXkI4rWVUwbEum3hxUEFvtu1bFpa+9UDEG4SC9NR4G25SpNhhTUv/N4xO 1uItGGFnZnggOB+9w3iKVaZriQSeI1kAlQo7iJ5HIHGX6jYGpEpc2VXAQGMkNwaokA0C pAqQsfDfXV2LMl+JPRN6d2iWUyBKdxDwA+OMSRLHQe82DDyzILm6SJpHEwMz/EFG+dlm w7iF987XktPYgdzSdDjfK3OywHIvDfK0ZKbF2u0rZEktoXShwhDYTVVGfF212Edg2ghO TLUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=kXOe724pI0nHKRZtSp++/O6E9r+hPQD982QjTdbSIH8=; b=YI9ZG8fM2YygeK/J2ecswQw/iIQralo8iwP2uWjOV3F3joy+Eqg3dzC5Jv2y+qkBDO b3Hawcbmk6bvZ1avNpR3FwPXFb1p96ox+J1MGdjzm6VsbNLmL9S+qJSU30z1XYK7yMbX yb3EO46yNBeD6/VL8f/q3tDoiR7TZx9w91kGQ4v+ny5SXL13GY59kvwQdZNKxd1qdN19 l4UAezcFb9fHw2pEW7Ar4FwMLGakHAi+r7rzDZDgh+rsVKGV/lbgFMxIZYO9N4BlBVuq bRtzkYBfZ70qWDFisR2DaczUg2Iq6nVM3c5qCsuP1CVLRb1fqc3WrB89daTIBT7BcrFJ 7lzA== X-Gm-Message-State: AD7BkJI6kWq1QUMGP+uWRsrkKsEZ1us4dTGFWLxzDg81QxKYbPIbwSggrZdYj6wv8W+K4g+I X-Received: by 10.194.133.161 with SMTP id pd1mr5528634wjb.66.1460051506712; Thu, 07 Apr 2016 10:51:46 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id 138sm31374312wmf.13.2016.04.07.10.51.45 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 07 Apr 2016 10:51:45 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Cc: dev@dpdk.org, Declan Doherty Date: Thu, 07 Apr 2016 19:51:44 +0200 Message-ID: <1681086.Z1ziI0Qxk5@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <57068423.4050007@intel.com> References: <1460035389-49395-1-git-send-email-pablo.de.lara.guarch@intel.com> <57068423.4050007@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] l2fwd-crypto: fix coverity defect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2016 17:51:47 -0000 > > When parsing crypto device type, the string was being copied > > with strcpy(), which could overflow the destination buffer > > (which is 32 byte long), so snprintf() should be used instead. > > > > This fixes coverity issue 124575: [...] > > Fixes: commit 49f79e86480d ("examples/l2fwd-crypto: add missing string initialization") > > > > Signed-off-by: Pablo de Lara > > > Acked-by: Declan Doherty Applied, thanks