From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3A5354291F;
Tue, 11 Apr 2023 23:13:42 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E44AF42D49;
Tue, 11 Apr 2023 23:12:43 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 9B82742BFE
for <dev@dpdk.org>; Tue, 11 Apr 2023 23:12:32 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id 6E3BB21779B6; Tue, 11 Apr 2023 14:12:31 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6E3BB21779B6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1681247551;
bh=jhTUgWeilKBAjrmCjPoBSgZHvxyQjz+9reT2vgJdjs8=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=EDN7l9rveI+FQ5JceaG9tM4n/B4N+f9tc5dtkT3kMUmm46o0IrDzZwDlnTvQbwS+L
rCh+kNcw/q7MbJ8a38D7pYv1wKJ48T9C3x06X7GpWg7WnUL2DInYFZVdqc2BUZuPkZ
tmr5ljx1WquXKzmyW56Vwi9V2ObYPbPD2wk5vBeA=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, david.marchand@redhat.com, thomas@monjalon.net,
mb@smartsharesystems.com, konstantin.ananyev@huawei.com,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v4 12/14] eal: exclude exposure of rte atomic APIs for MSVC
builds
Date: Tue, 11 Apr 2023 14:12:26 -0700
Message-Id: <1681247548-18590-13-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1681247548-18590-1-git-send-email-roretzla@linux.microsoft.com>
References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>
<1681247548-18590-1-git-send-email-roretzla@linux.microsoft.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
It's discouraged to use rte_atomics APIs instead standard APIs should be
used from C11. Since MSVC is a new toolchain/platform combination block
visibility of the rte_atomic APIs from day 1.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/eal/include/generic/rte_atomic.h | 7 +++++++
lib/eal/x86/include/rte_atomic.h | 4 ++++
2 files changed, 11 insertions(+)
diff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h
index e973184..1964697 100644
--- a/lib/eal/include/generic/rte_atomic.h
+++ b/lib/eal/include/generic/rte_atomic.h
@@ -131,6 +131,8 @@
/*------------------------- 16 bit atomic operations -------------------------*/
+#ifndef RTE_TOOLCHAIN_MSVC
+
/**
* Atomic compare and set.
*
@@ -1038,8 +1040,11 @@ static inline void rte_atomic64_clear(rte_atomic64_t *v)
}
#endif
+#endif
+
/*------------------------ 128 bit atomic operations -------------------------*/
+
/**
* 128-bit integer structure.
*/
@@ -1049,8 +1054,10 @@ static inline void rte_atomic64_clear(rte_atomic64_t *v)
union {
uint64_t val[2];
#ifdef RTE_ARCH_64
+#ifndef RTE_TOOLCHAIN_MSVC
__extension__ __int128 int128;
#endif
+#endif
};
} __rte_aligned(16) rte_int128_t;
diff --git a/lib/eal/x86/include/rte_atomic.h b/lib/eal/x86/include/rte_atomic.h
index ca733c5..b45ab28 100644
--- a/lib/eal/x86/include/rte_atomic.h
+++ b/lib/eal/x86/include/rte_atomic.h
@@ -82,6 +82,8 @@
#define rte_io_rmb() rte_compiler_barrier()
+#ifndef RTE_TOOLCHAIN_MSVC
+
/**
* Synchronization fence between threads based on the specified memory order.
*
@@ -278,6 +280,8 @@ static inline int rte_atomic32_dec_and_test(rte_atomic32_t *v)
#include "rte_atomic_64.h"
#endif
+#endif
+
#ifdef __cplusplus
}
#endif
--
1.8.3.1