DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>,
	Ciara Power <ciara.power@intel.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, "Laatz, Kevin" <kevin.laatz@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	"Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs
Date: Sun, 24 May 2020 18:05:53 +0200	[thread overview]
Message-ID: <1682317.61fhrPp9xr@thomas> (raw)
In-Reply-To: <20200522164818.GA887@bricha3-MOBL.ger.corp.intel.com>

22/05/2020 18:48, Bruce Richardson:
> On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> > On Fri, May 22, 2020 at 7:21 PM Ciara Power <ciara.power@intel.com> wrote:
> > >
> > > Initially, printf was used to indicate and error/warning resulting from
> > > telemetry initialisation. This is now fixed to use EAL logs for
> > > warnings, and the unnecessary printf for an error is removed.
> > >
> > > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
> > > Fixes: dd6275a424ac ("telemetry: fix error log output")
> > > Cc: david.marchand@redhat.com
> > >
> > > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > > ---
> > > --- a/lib/librte_eal/linux/eal.c
> > > +++ b/lib/librte_eal/linux/eal.c
> > > +               if (error_str != NULL)
> > > +                       RTE_LOG(WARNING, EAL, "%s\n", error_str);
> > 
> > "EAL: No legacy callbacks, legacy socket not created" comes all the times now.
> > Should we treat this as a warning? as it comes for with for the
> > built-in applications?
> > If it is important why not have a default handler in the EAL library?
> 
> Perhaps the warning level could be changed to INFO.
> BTW: if you compile with jansson library available, the legacy callbacks
> will be available and this will be silenced.

Applied with log level set as NOTICE.




  parent reply	other threads:[~2020-05-24 16:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22 13:48 Ciara Power
2020-05-22 15:00 ` Bruce Richardson
2020-05-22 16:34 ` Jerin Jacob
2020-05-22 16:48   ` Bruce Richardson
2020-05-22 17:00     ` Jerin Jacob
2020-05-24 16:05     ` Thomas Monjalon [this message]
2020-05-25  9:55       ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1682317.61fhrPp9xr@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=keith.wiles@intel.com \
    --cc=kevin.laatz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).