From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 959EEA04A4;
Sun, 24 May 2020 18:06:01 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 53C331D501;
Sun, 24 May 2020 18:06:00 +0200 (CEST)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
[64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 45ECF1DB9
for <dev@dpdk.org>; Sun, 24 May 2020 18:05:58 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailout.west.internal (Postfix) with ESMTP id C141E768;
Sun, 24 May 2020 12:05:56 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute7.internal (MEProxy); Sun, 24 May 2020 12:05:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
d9MVRz6EizWdp63aW5Cs0Ob7AsmALtnl/ZOKQRUclgE=; b=swpqqesUOoQAUgjE
nhXLekRGVEUFusiN+//oTv4fN+t2FwbLLnUze7Pa5bNqcVUzczkOMQB2qzMvNmLf
+9i2k1uIGZSmo99Sbdh2FNBQpUC/73PKFXNJtttdZTyatNXkJiJOqrWBjktkkkRZ
hYjdRQYkUdBy63JeTqbZGb3OoIL2I5g943J98MgtiuP89hoR02lqKvVhmQ0EqNUK
Cte+kGq2km+pdCIs2hr8thgV9vijWpucoaH/C1pBSfwrQWUuszseC0NGSF6PFBIW
N+i40qRnR8ad+fr8bcyc8Hf8xffvAZx6TMAsr1poHf/xcIHqMKP4p+zpRw2nKJgB
ZFOG1Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=d9MVRz6EizWdp63aW5Cs0Ob7AsmALtnl/ZOKQRUcl
gE=; b=Vge0x8q0Eanq0Oy4Ed+AZ+XmE+3DEaYJ1QZwSsIqNPVyXhAEqe7Rqa6dC
R5RwxTsK4PYpeyrAhHud1uBMAZVr+CFp4GnVwbVaYjDoRMbBcl6UCmYEVBKtumwS
8L7e3wbZ/BFuv9bUEYSeykuYkxYec60yGviZtyfEa884VrPxI7q/Te+fdBI50XX0
GUEg8bdaGzVIv3Bv6rn+nliBwS+qqYdBocpf7A3iW1X2bPtDiR4ql+X5dmDhYVrs
Is9qXcag8CT4bK93JLNaEgMMFDTAjP1YVT8OacUTDrA/hdrfVVsh2zbVcTaBPP5Z
4c4ROlnZOJRHW+0SSePpLzgeOAd8A==
X-ME-Sender: <xms:Y5vKXg8pbGHiyEIGXc3DWrS7Eag4crODtNJtqxjMA9dcK9Xjlw1dLw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddukedgleehucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:Y5vKXosRu8tVh6iQPjAZKHfWa_gcysobTDqI2-IiXjw-F4W_zDmu_Q>
<xmx:Y5vKXmCy7X0yCrsmhE20-naVev8epaLB_LVbG1QB0XQ0Q2Jrv0M0iQ>
<xmx:Y5vKXgef2iHnzJTfis_gNHDawULYL8r_BEpkGBkXnzhZeFG39-xjxg>
<xmx:ZJvKXqqTbxhjB0P0BEhDmH0Lt31z9ozKjfiuUNPehq6q0w19Yrlg3g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 02C49328005D;
Sun, 24 May 2020 12:05:54 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>, Ciara Power <ciara.power@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, "Laatz, Kevin" <kevin.laatz@intel.com>,
David Marchand <david.marchand@redhat.com>, "Wiles,
Keith" <keith.wiles@intel.com>
Date: Sun, 24 May 2020 18:05:53 +0200
Message-ID: <1682317.61fhrPp9xr@thomas>
In-Reply-To: <20200522164818.GA887@bricha3-MOBL.ger.corp.intel.com>
References: <20200522134839.15911-1-ciara.power@intel.com>
<CALBAE1P3cGPvOWZbBxPDswL=q3H6iWJgebYmdhz=PX2kGCVDfg@mail.gmail.com>
<20200522164818.GA887@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
22/05/2020 18:48, Bruce Richardson:
> On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> > On Fri, May 22, 2020 at 7:21 PM Ciara Power <ciara.power@intel.com> wrote:
> > >
> > > Initially, printf was used to indicate and error/warning resulting from
> > > telemetry initialisation. This is now fixed to use EAL logs for
> > > warnings, and the unnecessary printf for an error is removed.
> > >
> > > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
> > > Fixes: dd6275a424ac ("telemetry: fix error log output")
> > > Cc: david.marchand@redhat.com
> > >
> > > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > > ---
> > > --- a/lib/librte_eal/linux/eal.c
> > > +++ b/lib/librte_eal/linux/eal.c
> > > + if (error_str != NULL)
> > > + RTE_LOG(WARNING, EAL, "%s\n", error_str);
> >
> > "EAL: No legacy callbacks, legacy socket not created" comes all the times now.
> > Should we treat this as a warning? as it comes for with for the
> > built-in applications?
> > If it is important why not have a default handler in the EAL library?
>
> Perhaps the warning level could be changed to INFO.
> BTW: if you compile with jansson library available, the legacy callbacks
> will be available and this will be silenced.
Applied with log level set as NOTICE.