From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0057.outbound.protection.outlook.com [104.47.36.57]) by dpdk.org (Postfix) with ESMTP id 6E5F7DE3 for ; Tue, 24 Jan 2017 07:34:21 +0100 (CET) Received: from CY1PR03CA0020.namprd03.prod.outlook.com (10.174.128.30) by BN1PR0301MB0739.namprd03.prod.outlook.com (10.160.78.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Tue, 24 Jan 2017 06:34:19 +0000 Received: from BL2FFO11OLC015.protection.gbl (2a01:111:f400:7c09::174) by CY1PR03CA0020.outlook.office365.com (2603:10b6:600::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Tue, 24 Jan 2017 06:34:18 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; tuxdriver.com; dkim=none (message not signed) header.d=none;tuxdriver.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC015.mail.protection.outlook.com (10.173.160.81) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Tue, 24 Jan 2017 06:34:18 +0000 Received: from [127.0.0.1] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0O6YAH4001082; Mon, 23 Jan 2017 23:34:15 -0700 To: Neil Horman References: <20161222201700.20020-1-akhil.goyal@nxp.com> <20170120140509.4495-1-akhil.goyal@nxp.com> <20170120140509.4495-4-akhil.goyal@nxp.com> <20170120123237.GA15111@hmswarspite.think-freely.org> <80e5fc73-9a47-a3c5-db0a-1329810b1a39@nxp.com> <20170120193154.GB15111@hmswarspite.think-freely.org> CC: , , , , , Hemant Agrawal From: Akhil Goyal Message-ID: <16826234-24c1-7511-4948-6849050bb463@nxp.com> Date: Tue, 24 Jan 2017 12:04:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20170120193154.GB15111@hmswarspite.think-freely.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131297132585898520; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(2980300002)(1110001)(1109001)(339900001)(377454003)(24454002)(199003)(189002)(50986999)(6916009)(86362001)(4326007)(47776003)(54356999)(65806001)(6666003)(76176999)(2870700001)(2906002)(15395725005)(23746002)(31696002)(38730400001)(229853002)(77096006)(104016004)(92566002)(110136003)(2950100002)(93886004)(33646002)(356003)(120886001)(189998001)(65956001)(83506001)(54906002)(8656002)(6306002)(68736007)(31686004)(65826007)(64126003)(626004)(50466002)(7246003)(7126002)(8676002)(305945005)(81166006)(106466001)(36756003)(81156014)(53936002)(105606002)(8936002)(85426001)(97736004)(4001350100001)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0739; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC015; 1:3gaqZN2mmMCyWFHpDppVQ/i9eSVzw6Pp30Qv/O8Pq5I/3NqwT/iOAKvXBcTpckD2BEC+zcuCj2A5cH+dGJ1nKgQdECgtJEt/ufAFh5gXdjhtHYGdwRWEmH2oc0YKOWGgR9uSR4mPImf11sbKkUdB23I8O0ofwbwqRaRc559qv1D4/4D0MQgfn45Fj+zkf9crqshaZ47WxBlyfJErdhwOjaU9fGqXRzypexwx0wtjs6FfWSOv+rC/zApE/bLZdApXtk1824hVebpSR19TGUviKhFt4gHZaUKqWpnfAw7w0xdjDPmSWyD3ts6LYMcExcColZ6lH+9AajJvLdiUpH4DxQ4x+Ltlu2Ue/e13g4aET4R+g4FxLgkuq/o+Hr7fTuMTBvVlcicfmHFoiEmJtozVw1gthZlS/lluoFw0Iur4UmvJ6luEtin3yhjI8/wqUO6EKbI7Ww0mjucgM8fwar0oH2BKxtXVAfHbSgd+/B/zD2TBiciuRA4nNP4DV6zjYPrFD8WQbmvZCRHL/IuUcff3i6Nrl19Ua8Cgat+OBDNMynA8revr1siBBZq+hlFuW1TP/UWl3odsmBBCIMSCF8lzS+H2gvzz89Ss062Ql/Fy0Ug= X-MS-Office365-Filtering-Correlation-Id: 0505b584-352f-4815-5218-08d444230646 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN1PR0301MB0739; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 3:XeTgqYidG99OawQ8wTQGL5oOH1evlZfcH+r7TXi/zi1dO6DW+0Vl19QEMH5Asxo7BB9JO1NDpXQLWNrTz7x1jXzv2/29tppxPmDr/d6EjHvl/CiLooQzkEVRDeYg079lKxtnMuV93eRycJYLNWfvHge6O4MAKTkMEOQC/A/uXjBB65aqQ+OZlrp+3YwIwVrhAgLuqcuVy6+f57+1K8/tHCuinYXgLhy0mlfhNK6nzzHcpUcyhBdsclv6sBPhShskx+HheP+oV3szjLaWE9UDPO6t+O3GU1ST3uWSCAoL6Y+K9kvFPeUBVorLCgk9PedFhsTtpOqgHudafvvlkHs2Etpnm6Z+TiMsKffGYz/oQBchQHDK66nZeYnGighea3sH; 25:BE75CRAH8yMydkyD4mqjZTUY2HrbbOzHUw9VzTeW3vtRAEj4F5F9hIucqt4hDQ4hHDfOkJbITVLU+CTAh6iJE7kFqGbc0psb64VcY3eDoxMjtnbPgRF6A38ViFJj4+3v1GfTKP7qqJN+8YXiW5sGxsJ9qi9aROS5WAqnwdvcUMeMpilhjt5/xXP03aUjLx53XTA0ArGTzxrVjkbVRSJprSgZV1waqc/NK4VAtQaIPWNARuWFJnhC5gFoexpyjJPjhoYulIbEON2kXChhtGFjsLsSrx0pT4rmZClGCvdDaCVhdrT3GGjuwE8HZWz0atmLpFHr031/7/j6J21SBmuowOXDvbMjw5HVUy3EYCB3TZH9x3AmqBYo2kVwNVCcIbUmL7joAP6R5tX42zoeRZuAzkKpFZiYBKTiEfAcRx/BgWqWUNMZZNwRJhK8TRPGxq1fSaPECtaBPLGQUynV5AMcBg== X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 31:AKSGXIDbu3YswKtWowcl8QeY1Cgm3ov5/ICeMh77+2m09/eDd8eB4hJFtGIf4tutT0fKO4jX63ffajzaHnXbe7GSGsVcfraFpRdodPWi/WGlsICwSLBVNxnrpZjTsGkOxjdqFSirbxd+a43N42LmTI5HE7dSR0mCE8SwRRTAT9D4T9vUcg9Pre5DLnVp3JDZMiqgV7XKVtEB3TfWWJo+oqNeRHXv00EzgZxCia9fXyox9ZyyJ/hGOnebscA15d4d+slYhGqpC33fC64HRuQQjyBJNJQ1K0h9sW/znvt5hCA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13017025)(13015025)(13024025)(13023025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(20161123559025); SRVR:BN1PR0301MB0739; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0739; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 4:uOlk7v0YNIYrQQ2Ed+3p7s3o3wOS47ygM2F/x1l/IaHmzirPoSbHCWo3xGYiHWXQQ6mNKIqSIrCYXyRWyN2Vl2tCZQUteBJTzFFg5rwSMPvveS53iwZdwWMIeDdBpp0+p8ZH1Pl7+i9oLTJMcF1sPdoCupIRtVEa+9DqTZpVX16Uvud+7NeAgtHhNrOseMP9HlaswmD2Lo1FP9Jos5kx37QriR0Lt4t7lkAb5WTh1jY2Ujhb0mkOOsJvBXddqRKca00GdaXv2k6uDmv/OzbXPOTSEVuo59gLxYvZV6Vm7EL43oHk9F3LDVDDn9GGeHZL+/X/gClnNPwonVi73iXJ62a66mAwmoxaItqzR2thg7n/Gn0vrfb94TwozKNM0C83Xr/Z2wOf7oDEZrVwku3SE4H7E21bgT1tQb3FXu9H6AuE9PGLaG4VlLkZaq6Qd4B3cs50POto+HfIEl61DFG9oGFQhMadEsVHWLk/KmU0iq9puDxQC99NNGOgMoilA5rP8YG03ycUM88t2a2mj6hDT2UScN/RGg6ITuhudTM67oCeFDPizqT87ERlPT0MPxflR9NmZgnu5bdyw3+BMVQA/iP3VXmXg0ulwOD/rkwGKNOM+F9KRqtrSRu8jn6YQ0lhFAeleSJ3YFDWkKdzQtWJ9GT6eN1XuteRcmklDZK58oGeVQo/Bx/s3sLLqOIi+qMsdOsFBs+Exme1wVXyW7GSMBSbluObZ6SE3e4+X3V3gGzs9ylE2tFIE84GniwnS7Si X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN1PR0301MB0739; 23:YX8IsbT0kt+znKkPkTjcHVVIgG4Af2cMr7U?= =?Windows-1252?Q?7I6qbImSVZ6abYVgGlawZo6K5VDr6wj5BGO9PMSHDTgpKr6YHvVggvGP?= =?Windows-1252?Q?ovsxB0qo8m95geEN9yRm06cqGsfRGTU10Jo8E4g5y3VFZNPxVpw4ZiXu?= =?Windows-1252?Q?nQ+hfc0+VXXNDDxNr+9+fLEsnudNDmULPF9xgBGOIy847tfgwVaQ+cOV?= =?Windows-1252?Q?HnVeEKSuhbcHDH9bRrxiiRJwDHBr6S2I5KDRLS3+csnI9Iqo/Q5aJ4V0?= =?Windows-1252?Q?gmbl38v96Vj+qT6HrJurtcLw5w5gbrFuRGz+92jlEvozsEdrsuTXSRh0?= =?Windows-1252?Q?fnCCIBF7bJvGenl2nnruNHUomPuJWQAYJRxlM6SIBYiOBSoWjCRm3j+R?= =?Windows-1252?Q?7GZ4JmTxW0pL3Y5j3KAJo5auZqxlXi3ArZtH3kRor8Y2YKvJp5eE3Poj?= =?Windows-1252?Q?DyEvxlCMRBGisIzbN/3fnozMJh52qhQsgU+st5OpiA9Ve1e5nt3A+DZX?= =?Windows-1252?Q?SlSZQcKDE5syxVluYY1E6CwmgEw0d5RrascaRw1X7muinwLnJj8ldRdq?= =?Windows-1252?Q?35fc0cIrFQYmKDJjsItAVLwXFqH5s7epcTDBUfSEQg+aAgXSvEGRQ24F?= =?Windows-1252?Q?DzQaDdxvtxoF3q9hzEnsneV6n8WBMF4EBTjmzRHcKB8NCWDtxKJjHHtU?= =?Windows-1252?Q?xS13Zkftq5Jm7t1yMPgYHB7xQS1WilzxL+qaJhcReH9Oi1S84ExEBMdd?= =?Windows-1252?Q?htLONDkBt/o5cmm4zSNdRufU6nx0sS5G0TKJkLBNPQwgWd6aKfOnZt6w?= =?Windows-1252?Q?L6NACIWUWPlxMB1GdA5NNaml95hGP0qWRK57mgUZre+VhhNE9tDeZsat?= =?Windows-1252?Q?/q7rgSb4CDkVhE+ZsEXOR9hB9Sp52pLFt1xCDqzOpHYFzwdVFciAuRYA?= =?Windows-1252?Q?s3hf6siMUgAVg2xqcCCqJtDKKUUzEy9/mg8G+zGLWmZ/hp4ng9XhMZPJ?= =?Windows-1252?Q?ORKMc14tW1B7KOe+GhiBIb1boZC+wRI6GvMAb+1IUUDAGiGGnn5p4Kcr?= =?Windows-1252?Q?q6LMsKtyWi+qcVxHlFkOG+JF0TiELyTk0ghfVRDNDCwnJ+4STFowBDht?= =?Windows-1252?Q?K8TU1X6ux67yKKb5SI2Z0tde2uOgZ1B12PXWUkuX/d5Nfy64JV6ID6wi?= =?Windows-1252?Q?m08BnO7rFpH/PyWZ+e8kRzcyI9IJP5MLRdMSA7dDEL/iwmgHobe8kr9G?= =?Windows-1252?Q?T/AigiFqtdzAnujv38g9Rw8kM4yc6tINLZjoVXCpBsc6CKXM4+EbHJhF?= =?Windows-1252?Q?3H0xdtVS+qj5ImRyTXPFB2L7O1EdQYYWigPjIHCNIVcMez7yTtljvOJI?= =?Windows-1252?Q?vOgm8bweGTGiuD/5+7fAhCb79oVdOwkXXcrQrQK/zPKixILCZCcQPCFr?= =?Windows-1252?Q?XjqMXusVrh8Dm7VkZe/krTuxhO4NNB/aWtGjodWtfLA00i8aYXUGjFwm?= =?Windows-1252?Q?sUiybUoJEsOWoCjTlhVsT5t6SUZ/JjZ7SBZnTPUuVJYuWbqCzt8rDkY9?= =?Windows-1252?Q?EQWXYoNh7+DYMDxSZfFwBQCadNKn1qoj2GhQs?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 6:YoWCfAh/6biGKsDVze2ChtwSbws4y1IdcMhyyc/TjgthLyI8tIfsPaPKxSWPkV3VCjPgZsZ+JOVYDWP1BloFnwlSSNtRMimC01n03YLugE3GG35MJLXlbZFRMxvziRmATqJNpoAojwLI2uz1GYOEoPfsHgFkJScsG7f4umC7HhQ82wnnko9PEKPKvOCY/ON8l7ygHti3Hr6cmpJe/hNiROaQWS8W5O4XQ4fwNA1k5NiaSF98x1/0pORgHbABhnjENx7S9M66QoP1ihWO8mfuAnSkHSbcUAf4NY6zG1+jxxAO44P/tz/WjC4SBA6Gyhxp21NKBrvdzQ4WOJHmp1Y17/vbnSBgoItf/nWLGiltX7WmLbwW4/Oq5ALi9qHA+9kelbWkCJqZHSEUp29GRW+hKE+a1sZRBFcO7aq6nSjIPQLLB4AqCGnJWb/LxZamp/U1; 5:OidrmYnVNJPrS5eL7Ema6nv4BkccxoEUd6z/RTZCFtZ8OlX+qXt3dl4gt8iXS2B2kBEdE6YxrFQY8s/XFduSfyQhGvcLm4RszqvNIww2vzR5Iu1qFh26BXeGOcn5hrQyvIOcHXTNJNEWDcocKekrvK6eimZlPBWMJC8kXLw8lS53amnLAbOwOvwoAawydND1; 24:mo/DssbNzmZKJI5B2Jejh5+9KxiLvgR6WTNeOJehnYKmwUCcrEsF0VWVwiROZgi9Mcd2lA/kp74mEOMe0y3lIo2dx+F/TH7i0VSABeB4TO4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739; 7:VbVNelZFKeFnlakT0sUhC5ArHhGckEpU2bWsaWOGJu7y5cDkBII3ijxwurGDqX1gVXsdddAYJk5ZmQwzVEKSOjdrr9Pv/3WWOVERwTJV7BcGZ38JsXl4zfW8HLCJshcLIX5UATvhesvAGZemI43Rw4yC1vGP/KoLnzL4Fn3V5TqGBRKgOpic0Oupj/KtcisdjePq7EsPCyu0Sak9g5qLqeYKndEpOeJDvJI8+skgcdmjL5JhfGiekNnpraNmUbzu3tVnfmy8/hthUb40W5BCkYxDqXXFYEbB8ifaJP4rGXNhZfATrcGV6qxcQfWtQfF4FpDu9G9mIGX+iNN2BHRlne43BSn4S4H7ovh6ZsVSU27BQ0/bCvJIUwQ/NgbA/lU0sGbnFmvT5PrLwnjbztvbNZ36qpxJY/9u1QbKhAAltWsWe+TF/1TbQ3tKk/Zn3Io2QiiXWxkUl9IR9ZtsFuRivA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2017 06:34:18.3870 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0739 Subject: Re: [dpdk-dev] [PATCH v3 03/10] crypto/dpaa2_sec: add dpaa2_sec poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 06:34:21 -0000 On 1/21/2017 1:01 AM, Neil Horman wrote: > On Fri, Jan 20, 2017 at 06:47:49PM +0530, Akhil Goyal wrote: >> On 1/20/2017 6:02 PM, Neil Horman wrote: >>> On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.goyal@nxp.com wrote: >>>> From: Akhil Goyal >>>> >>>> Signed-off-by: Hemant Agrawal >>>> Signed-off-by: Akhil Goyal >>>> --- >>>> config/common_base | 8 + >>>> config/defconfig_arm64-dpaa2-linuxapp-gcc | 12 + >>>> drivers/bus/Makefile | 3 + >>>> drivers/common/Makefile | 3 + >>>> drivers/crypto/Makefile | 1 + >>>> drivers/crypto/dpaa2_sec/Makefile | 77 +++++ >>>> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 374 +++++++++++++++++++++ >>>> drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 70 ++++ >>>> drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 225 +++++++++++++ >>>> .../crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 4 + >>>> drivers/net/dpaa2/Makefile | 1 + >>>> drivers/pool/Makefile | 4 + >>>> mk/rte.app.mk | 6 + >>>> 13 files changed, 788 insertions(+) >>>> create mode 100644 drivers/crypto/dpaa2_sec/Makefile >>>> create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c >>>> create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h >>>> create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h >>>> create mode 100644 drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map >>>> >>> NAK, you're trying to patch driver/bus/Makefile, which doesn't exist in the >>> upstream tree, please fix your patch. >>> >>> I'm also opposed to the inclusion of pmds that require non-open external >>> libraries as your documentation suggests that you require. If you need an out >>> of tree library to support your hardware, you will recieve no benefit from the >>> upstream community in terms of testing and maintenence, nor will the community >>> be able to work with your hardware on arches that your library doesn't support. >>> >>> Neil >>> >> Thanks for your comments Neil. >> dpaa2_sec driver is dependent on dpaa2 driver which is in review in other >> thread. I have mentioned that in the cover letter. >> Its latest version is http://dpdk.org/dev/patchwork/patch/19782/ >> > Sorry, I missed that comment, I'll go find the other thread and take another > look > >> Also there is no external library used. The libraries that are mentioned in >> the documentation are all part of the above dpaa2 driver patchset. >> > Your documentation patch doesn't seem to suggest that. From the patch: > > +This driver relies on external libraries and kernel drivers for resources > +allocations and initialization. The following dependencies are not part of > +DPDK and must be installed separately: > + > +- **NXP Linux SDK** > + > + NXP Linux software development kit (SDK) includes support for family > + of QorIQ® ARM-Architecture-based system on chip (SoC) processors > + and corresponding boards. > > .... > > If thats not the case, you should update the documentation. If it is the case, > I think my initial comment is still valid... > > Regards > Neil > >> -Akhil >> >> >> > Thanks for pointing this out. I will update the documentation. Regards, Akhil