From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 89C95388F for ; Wed, 7 Dec 2016 21:09:14 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id c184so37765756wmd.0 for ; Wed, 07 Dec 2016 12:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=mtCfIFD8+uqvx3e8yVfei8nsoXd1WQ0mGPteqWo7mUM=; b=g7ibGZHb1KaM/Rr4r5rXodUhQXOGYINLVjweMWjfjU57jnOmTNXOPMEX5R+HnIR2H3 Na0xnhY8P3TVEv6Nc8YPyo3SJz0w07XoJI1dehTU4mkc+6TTiS3znyi+xDPJUjn1dXW5 LieYXdx9NIILRUkqkaEvpOBUgxzXel2RtOixqhEZrH4xe87sfUlBH1fGEM+4f54WcaRe v/UpOZRo7ehzfNMsV+wooswWZXYggJdNTJD9nu5bbuAl5T3QRRIfVMoaOCj9E9N82A1i wmj6pef5c2QLI33GhuvJg3GRZnbhFMhlQocbbLuFqrxxL7uc0+FkJvYtBrLpGCzTrW+o /+7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=mtCfIFD8+uqvx3e8yVfei8nsoXd1WQ0mGPteqWo7mUM=; b=dOAeAQO4Gopz6J4Idx5VaqwDWVUqLLuTqb7NwysXWr3lt823Wjz/clFR258R1uVaeK hjzSj2iknmKNvL4ObdTG+h0TtB/8QaqcFBPEDP/dfXRLc0IKVXPSsw+ne6xp5aNI+jqn aFH1tGI3iUfJVFcWBqMTOr4pM/w4knG6ji7IahU5X60OJo7oeU5e87UGf/eAzXFK4Diw jMyjRODschAyaVcBsluGQBSbuiD1CGN6zZ+poDbfbIlepYhKd7M/qzJ/a4vt6b9eLGe6 71vPkf7gWa7uRn2SDXsxqDDf9xXFSvW6vG5rvl/9RFK9Q8qtBFzSt4VCy+1lmgs2VtQG 6W9Q== X-Gm-Message-State: AKaTC02ThiTAHpb1E0K1GhfwBLHBfXTx4oN8tjiJ66ihjMy7mxEEAhw4Y/jOQkPNZ16Cadyx X-Received: by 10.28.232.16 with SMTP id f16mr4110207wmh.103.1481141354169; Wed, 07 Dec 2016 12:09:14 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id j6sm33199800wjk.25.2016.12.07.12.09.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 12:09:13 -0800 (PST) From: Thomas Monjalon To: Zbigniew Bodek Cc: dev@dpdk.org, zbigniew.bodek@caviumnetworks.com, pablo.de.lara.guarch@intel.com, jerin.jacob@caviumnetworks.com, declan.doherty@intel.com Date: Wed, 07 Dec 2016 21:09:12 +0100 Message-ID: <1683862.k80B36XYkt@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2cec934f-b645-be28-8e82-a271692260d0@caviumnetworks.com> References: <1480851219-45071-1-git-send-email-zbigniew.bodek@caviumnetworks.com> <4126251.ynkckbu1rM@xps13> <2cec934f-b645-be28-8e82-a271692260d0@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 02/12] lib: add cryptodev type for the upcoming ARMv8 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 20:09:14 -0000 2016-12-07 20:04, Zbigniew Bodek: > On 06.12.2016 21:27, Thomas Monjalon wrote: > > 2016-12-06 18:32, zbigniew.bodek@caviumnetworks.com: > >> From: Zbigniew Bodek > >> > >> Add type and name for ARMv8 crypto PMD > >> > >> Signed-off-by: Zbigniew Bodek > > [...] > >> --- a/lib/librte_cryptodev/rte_cryptodev.h > >> +++ b/lib/librte_cryptodev/rte_cryptodev.h > >> @@ -66,6 +66,8 @@ > >> /**< KASUMI PMD device name */ > >> #define CRYPTODEV_NAME_ZUC_PMD crypto_zuc > >> /**< KASUMI PMD device name */ > >> +#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8 > >> +/**< ARMv8 CM device name */ > >> > >> /** Crypto device type */ > >> enum rte_cryptodev_type { > >> @@ -77,6 +79,7 @@ enum rte_cryptodev_type { > >> RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ > >> RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */ > >> RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */ > >> + RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */ > >> }; > > > > Can we remove all these types and names in the generic crypto API? > > > > Hello Thomas, > > I added another PMD type and therefore we need new, unique number for > it. I'm not sure if I understand correctly what you mean here, so please > elaborate. My comment is not specific to your PMD. I think there is something wrong in the design of cryptodev if we need to update rte_cryptodev.h each time a new driver is added. There is no such thing in ethdev.