From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: suppress error for reference of packed members
Date: Wed, 25 Jan 2017 11:08:24 +0100 [thread overview]
Message-ID: <1684540.y5zCPFlYWp@xps13> (raw)
In-Reply-To: <20170124210419.14084-1-emmanuel.roullit@gmail.com>
2017-01-24 22:04, Emmanuel Roullit:
> Found with clang build:
> error: taking address of packed member 'mlock' of class or structure
> 'rte_mem_config' may result in an unaligned pointer value
> [-Werror,-Waddress-of-packed-member]
>
> Fixes: 29361d4c91ed ("mk: fix build with clang < 3.5")
> Fixes: b2bb3a5daaac ("mk: stop on warning only in developer build")
I think these references are not correct.
The bug is due to a new version of clang, so no Fixes: tag is needed.
You should put "clang 4" in the title.
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> ---
>
> v2:
> * Only apply compiler flag on clang >= 4.0
Please use --in-reply-to for grouping v2 patches with v1.
> --- a/mk/toolchain/clang/rte.toolchain-compat.mk
> +++ b/mk/toolchain/clang/rte.toolchain-compat.mk
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -ge 40 && echo 1), 1)
> + CC_PACKED_MEMBER_WERROR := true
> +endif
> --- a/mk/toolchain/clang/rte.vars.mk
> +++ b/mk/toolchain/clang/rte.vars.mk
> +ifeq ($(CC_PACKED_MEMBER_WERROR),true)
> +WERROR_FLAGS += -Wno-address-of-packed-member
> +endif
So you are completely disabling the warning?
Can we assume this warning is of no interest?
next prev parent reply other threads:[~2017-01-25 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 21:04 Emmanuel Roullit
2017-01-25 10:08 ` Thomas Monjalon [this message]
2017-01-25 20:52 ` Emmanuel Roullit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1684540.y5zCPFlYWp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=emmanuel.roullit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).