From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 274355F12
for <dev@dpdk.org>; Mon, 17 Sep 2018 13:46:29 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id A17582102F;
Mon, 17 Sep 2018 07:46:26 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Mon, 17 Sep 2018 07:46:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=mjylgXGxWOoN80iG3hcSbXrP8S
PITVLipRiCr1VyyPc=; b=qM8elx7TJKw6eoFxMZKdwR5bSK6fIjJsxho+sqB449
m9STm/jULDY+BRIjtjN06hu/JLOndDMHFniSuTCu4Zz7pR4MqeHNMmqavzJtwblP
D8Ck+l2ZIO7Zk4ULwQy/VZK6GZDgHU1qTrMJVXtbfI33FT1YLcquK+7WQbWyzIxN
M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=mjylgX
GxWOoN80iG3hcSbXrP8SPITVLipRiCr1VyyPc=; b=Y89yvXxdlT52rjiFL5gOzS
YaxI5t+u1iT8qb+XBPsOHXu8m2Q+N9zqfvIOdt6Nh1per9QRzV5lD9+OqN5WgG9O
NATvQpuyx7JhM5ciOMz2Pdds9+BhHrOuhI/TZqPsdhULpFt8sgVQ83aoRRx5ELfa
wWaAN+/aRSumee70X5Ek7l8WPqWppGKyCa4y8+Ut6sZZmEgwIRDzdwwW1lnJQ+Hs
uJs68dOcIdQaZ3/PzIJhXN43j4RKdsp0/8SG/qcTNAUyx7OlnUnLbEspGc6f/6oA
vb0smId4nm+6D55g/cd9nnKJcg7neHTqvi8vPmAHnyt/PRKLpxWtoXwN3m/FSq3A
==
X-ME-Proxy: <xmx:EZSfWyoVfgq1nEPUMBT4dq4QsVo-zt-EiHSOMp6l9ZxJ3vk62kqtbw>
<xmx:EZSfW6AK0X4mdEk5BbF9CJOQWtseZ7oo94orJrlhm1N46A_-8h9SJg>
<xmx:EZSfW_uDDCqU2bswzh-bnDh_moiAIiWapBOcU_4ovgOYmpXRe_nwdg>
<xmx:EZSfWxYyhLclvplz4cEnlqziGq3uWYJcdn8LA9s2g_wOty_eCMB5KA>
<xmx:EZSfWzEdPgcYsXkeNw86Jeq1lw-7nBmSeCcF1jP7g3A5ELmb6OQMgw>
<xmx:EpSfW4F_-KC1p7w9CECQVjuoOQkCmCGS6SA8wIifM3S3t3tjZRf9Jg>
X-ME-Sender: <xms:EZSfW0Kh4m55EuKyYXOMEq7qbIjkg94uHuYGuwAjzbp8gDXgZNiUrQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id BC646102D9;
Mon, 17 Sep 2018 07:46:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anoob Joseph <ajoseph@caviumnetworks.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Anoob Joseph <anoob.joseph@caviumnetworks.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org,
Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>,
Murthy NSSR <nidadavolu.murthy@caviumnetworks.com>,
Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>,
Ragothaman Jayaraman <rjayaraman@caviumnetworks.com>,
Srisivasubramanian S <ssrinivasan@caviumnetworks.com>,
Tejasree Kondoj <kondoj.tejasree@caviumnetworks.com>, ferruh.yigit@intel.com,
john.mcnamara@intel.com
Date: Mon, 17 Sep 2018 13:46:22 +0200
Message-ID: <1686325.VlSG2WtMdx@xps>
In-Reply-To: <d5860f61-29d7-2138-08a0-d075b1c0b10c@nxp.com>
References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com>
<1536033560-21541-6-git-send-email-ajoseph@caviumnetworks.com>
<d5860f61-29d7-2138-08a0-d075b1c0b10c@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for
init routine
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 11:46:29 -0000
17/09/2018 12:45, Akhil Goyal:
> On 9/4/2018 9:28 AM, Anoob Joseph wrote:
> > +struct pending_queue {
> > + uint16_t enq_tail;
> > + uint16_t deq_head;
> > + uint16_t soft_qlen;
> > + /**< Software expected queue length */
> > + uint16_t p_doorbell;
> > + struct rid *rid_queue;
> > + /**< Array of pending requests */
> > + uint64_t pending_count;
> > + /**< Pending requests count */
> > +};
> better to add comment for each element of structure.
> Also remove extra tab for comments(here and any other place if any.)
I don't understand this trend in the community about doing comments
_after_ the item _and_ not on the same line.
The default style should be commenting _before_.
And if you feel it is better to have the comment on the same line,
then you can comment _after_, but on the same line.