From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3D4D25323 for ; Mon, 1 Apr 2019 18:59:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C325721FF3; Mon, 1 Apr 2019 12:59:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 12:59:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2vHEM3I8NJXE+uZwP4SXb9a9DOXQKxG3ZLoUE2qOmz4=; b=KakBh6q8S8pY UDrUD+lHdhOVEV+n4Exw/XcH50/n6ff+4ACJ+R/zPIsASh1k+0bXSS3iJ/otelRt DF+iFB0Yo7/IBtRvGM0aTu8/jSO3lIs86IXruZKh2A0/noaAud7egCp2VFtNjOZv 7ZlyH7aUu10YnBeTglWa9UadKSsHSYk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2vHEM3I8NJXE+uZwP4SXb9a9DOXQKxG3ZLoUE2qOm z4=; b=JSmyLklOxckqkGYQgMDY6t4J8rpkrQu9f/zYCe6MfwQQfvTgevU3N1jwx fugbmzUDZekvJeCc3Yt0o2J50LfwlrXJ//rHKPvT531FOa0fvEAkj5SJpaOmZRPy 1fgu/3Gg2/2/MksK/yVbqw/+T2nrU94QYYjROf9yxuca66maSYXQe0UX71CYz9fN w6sHnvVgD9RpKIjViAEMYk/VLuxo6rJCoTt8wVScNCoVf6jCxDKLGp7JEn1sdezt 45GQ1UYGc9Qht6qXaf1sglGVXasGITLE+PyvInAHXwltFU1C38VRputRl5JecP+f F5G30GUYO5Y6VoT8Q5bHfpxLFDNdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepkedurddukeehrddujedvrddvuddu necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (211.172.185.81.rev.sfr.net [81.185.172.211]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E47EE46B8; Mon, 1 Apr 2019 12:59:13 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Ali Alnubani Cc: dev@dpdk.org, "ferruh.yigit@intel.com" Date: Mon, 01 Apr 2019 18:59:11 +0200 Message-ID: <1686605.rchtxGbhtY@xps> In-Reply-To: <20190401154830.GA1452@bricha3-MOBL.ger.corp.intel.com> References: <20190401103551.28909-1-alialnu@mellanox.com> <20190401153836.30807-1-alialnu@mellanox.com> <20190401154830.GA1452@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] build: use cat if found X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 16:59:16 -0000 01/04/2019 17:48, Bruce Richardson: > On Mon, Apr 01, 2019 at 03:38:59PM +0000, Ali Alnubani wrote: > > This is to fix a build error with meson in GNU/Linux that is caused > > by using the 'more' command to read the VERSION file. The error: > > > > config/meson.build:10:10: ERROR: String > > '::::::::::::::\nVERSION\n::::::::::::::\n19' cannot be > > converted to int > > > > The command 'more' prints the file name before the actual > > contents of the file when it's being run without a controlling terminal. > > This could happen in CI environments. > > > > Please refer to: > > https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/text-utils/more.c > > > > Fixes: c04172b5f031 ("build: add single source of DPDK version number") > > Fixes: d320fe56bd51 ("build: use version number from config file") > > > > Signed-off-by: Ali Alnubani > > Signed-off-by: Bruce Richardson > > --- > > Changes in v2: > > - Use find_program to fallback to 'more'. > > - Update patch title. > > > > meson.build | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > Thanks for the V2, code change looks good now. For the title, I think this > is really a bug-fix so I'd suggest something like: > > build: fix meson build in CI environments > > as more helpful. [Thomas, can you correct on apply, or do you want a v3?] Applied with title changed, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D193CA0679 for ; Mon, 1 Apr 2019 18:59:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF75F548B; Mon, 1 Apr 2019 18:59:17 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3D4D25323 for ; Mon, 1 Apr 2019 18:59:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C325721FF3; Mon, 1 Apr 2019 12:59:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 12:59:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2vHEM3I8NJXE+uZwP4SXb9a9DOXQKxG3ZLoUE2qOmz4=; b=KakBh6q8S8pY UDrUD+lHdhOVEV+n4Exw/XcH50/n6ff+4ACJ+R/zPIsASh1k+0bXSS3iJ/otelRt DF+iFB0Yo7/IBtRvGM0aTu8/jSO3lIs86IXruZKh2A0/noaAud7egCp2VFtNjOZv 7ZlyH7aUu10YnBeTglWa9UadKSsHSYk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2vHEM3I8NJXE+uZwP4SXb9a9DOXQKxG3ZLoUE2qOm z4=; b=JSmyLklOxckqkGYQgMDY6t4J8rpkrQu9f/zYCe6MfwQQfvTgevU3N1jwx fugbmzUDZekvJeCc3Yt0o2J50LfwlrXJ//rHKPvT531FOa0fvEAkj5SJpaOmZRPy 1fgu/3Gg2/2/MksK/yVbqw/+T2nrU94QYYjROf9yxuca66maSYXQe0UX71CYz9fN w6sHnvVgD9RpKIjViAEMYk/VLuxo6rJCoTt8wVScNCoVf6jCxDKLGp7JEn1sdezt 45GQ1UYGc9Qht6qXaf1sglGVXasGITLE+PyvInAHXwltFU1C38VRputRl5JecP+f F5G30GUYO5Y6VoT8Q5bHfpxLFDNdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepkedurddukeehrddujedvrddvuddu necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (211.172.185.81.rev.sfr.net [81.185.172.211]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E47EE46B8; Mon, 1 Apr 2019 12:59:13 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Ali Alnubani Cc: dev@dpdk.org, "ferruh.yigit@intel.com" Date: Mon, 01 Apr 2019 18:59:11 +0200 Message-ID: <1686605.rchtxGbhtY@xps> In-Reply-To: <20190401154830.GA1452@bricha3-MOBL.ger.corp.intel.com> References: <20190401103551.28909-1-alialnu@mellanox.com> <20190401153836.30807-1-alialnu@mellanox.com> <20190401154830.GA1452@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] build: use cat if found X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401165911.Ij5U4vYQrxtYQ34XaO8JmS8pzdFevSNW4FdugQ8gmLY@z> 01/04/2019 17:48, Bruce Richardson: > On Mon, Apr 01, 2019 at 03:38:59PM +0000, Ali Alnubani wrote: > > This is to fix a build error with meson in GNU/Linux that is caused > > by using the 'more' command to read the VERSION file. The error: > > > > config/meson.build:10:10: ERROR: String > > '::::::::::::::\nVERSION\n::::::::::::::\n19' cannot be > > converted to int > > > > The command 'more' prints the file name before the actual > > contents of the file when it's being run without a controlling terminal. > > This could happen in CI environments. > > > > Please refer to: > > https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/text-utils/more.c > > > > Fixes: c04172b5f031 ("build: add single source of DPDK version number") > > Fixes: d320fe56bd51 ("build: use version number from config file") > > > > Signed-off-by: Ali Alnubani > > Signed-off-by: Bruce Richardson > > --- > > Changes in v2: > > - Use find_program to fallback to 'more'. > > - Update patch title. > > > > meson.build | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > Thanks for the V2, code change looks good now. For the title, I think this > is really a bug-fix so I'd suggest something like: > > build: fix meson build in CI environments > > as more helpful. [Thomas, can you correct on apply, or do you want a v3?] Applied with title changed, thanks