From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9544A4C9D for ; Mon, 30 Jul 2018 11:50:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D955B215C6; Mon, 30 Jul 2018 05:50:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 30 Jul 2018 05:50:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=8mOeud5XkgI7CVKuUZzKuomVO4 y1VTieu080q32ZeuM=; b=WjVHFzyP0OnlHFiar6h5xQCmnh8cZPJwMW5704UO3R i97Ih+3uoJDicWJvJnzFfxtyMvyRhCRrzMnxz2bhyjUg+633M9k9wvqKJ7JW6W8a i5FDp5A9EXV52DvFcoqp/hqBVi5y76u1oBeA/z00f4+NbAlQqkLrSIp93VHpgBsp Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=8mOeud 5XkgI7CVKuUZzKuomVO4y1VTieu080q32ZeuM=; b=TLn0SUQ1DwBol8bKStP/uc akM3s6gYV0LCaTujWmiy2cJpeMLHAQOlR3LrGTMdgFjxV1DvEAkr70UKYfJ0q1Bf 0fDepUr4CBOZWu/MYJmgfyX9rIZjBonCh+f8fGLsJOnaXlCrXx91wOKDORqJrrGf E7qMfAyC+H+o2FvCWzuw91BW/fEQ3Tad09VxUyvDypitqYOcvGPqFRKt99ij66vu XBYe3iaSgdbQfNgeMHoSKCSKTUVyCl8bnE2sLqEK2pOWiF5Myjb/ZNAJsVBGKqbP Xoc8LQgwJJSm+9QeYwWXapiPWsIyiqek1IPpAXrEvNsEq87ukWcHWX7cwLIDLluQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 95B1010276; Mon, 30 Jul 2018 05:50:55 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , "Ananyev, Konstantin" Cc: dev@dpdk.org, "Yigit, Ferruh" , "shahafs@mellanox.com" Date: Mon, 30 Jul 2018 11:50:50 +0200 Message-ID: <1687236.JLa48GYJ5r@xps> In-Reply-To: <20180730093555.GA22823@jerin> References: <20180729124409.3669-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB977258DF51F641@irsmsx105.ger.corp.intel.com> <20180730093555.GA22823@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 09:50:57 -0000 30/07/2018 11:35, Jerin Jacob: > From: "Ananyev, Konstantin" > > > > > > As of now, application does not check PKT_RX_*_CKSUM_* flags per > > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not. > > > > > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few > > > cycles if possible. > > > > Personally, I'd move in other direction: keep RX checksum offload and add > > checks inside sample apps to handle (drop) packets with invalid checksum. > > OK. Till someones add the DROP logic in application, Can we take > this patch? Because there is no point in enabling DEV_RX_OFFLOAD_CHECKSUM > without DROP or any meaning full action in application. If there is no patch sent to use this offload on August 1st, then I will apply this patch to remove the offload request.