From: Thomas Monjalon <thomas@monjalon.net>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org, nic@opencloud.tech
Subject: Re: [dpdk-dev] [PATCH] pci: limit default numa node to used devices
Date: Fri, 21 Jul 2017 17:53:01 +0300 [thread overview]
Message-ID: <1688226.sl7kgNVU6i@xps> (raw)
In-Reply-To: <20170721091119.15701-1-sergio.gonzalez.monroy@intel.com>
The title and the text below should explain that you move
the warning log from scan to probe, thanks to a temporary
negative value.
21/07/2017 12:11, Sergio Gonzalez Monroy:
> Commit 8a04cb612589 ("pci: set default numa node for broken systems")
> added logic to default to NUMA node 0 when sysfs numa_node information
> was wrong or not available.
>
> Unfortunately there are many devices with wrong NUMA node information
> that DPDK does not care about but still show warnings for them.
>
> Instead, only check for invalid NUMA node information for devices
> managed by the DPDK.
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
[...]
> - if (eal_parse_sysfs_value(filename, &tmp) == 0 &&
> - tmp < RTE_MAX_NUMA_NODES)
> + if (eal_parse_sysfs_value(filename, &tmp) == 0)
> dev->device.numa_node = tmp;
Why are you removing the check of the value?
Are you going to accept invalid high values?
This check was introduced on purpose by this commit:
http://dpdk.org/commit/8a04cb6125
next prev parent reply other threads:[~2017-07-21 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 9:11 Sergio Gonzalez Monroy
2017-07-21 14:53 ` Thomas Monjalon [this message]
2017-07-21 15:03 ` Sergio Gonzalez Monroy
2017-07-21 15:37 ` Thomas Monjalon
2017-07-21 15:47 ` Sergio Gonzalez Monroy
2017-07-21 16:26 ` Thomas Monjalon
2017-07-21 16:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1688226.sl7kgNVU6i@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=nic@opencloud.tech \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).