From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 70C7C271 for ; Fri, 21 Jul 2017 16:53:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 10DAB20B83; Fri, 21 Jul 2017 10:53:08 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 21 Jul 2017 10:53:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ID3t6LyZNBfv9tJ L/rgSFxEJB3ddPTKBKaSbkkJWAu4=; b=a42p3vzImCfgs1P453sMj13hJkqjP6o I8dMCrjN67/1j2M8IiVuMypH/TIhgkM7Bm9S/npmeGsYWeVKueg/Zqrrz9+QHZwv UCeRbNKZ9lB6GkZ4bLkEdu/6qeje8QDSB+NCwqyaFu97wQf/r8+7OiiSXVBQURgI NUiFQpO1+fD4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ID3t6LyZNBfv9tJL/rgSFxEJB3ddPTKBKaSbkkJWAu4=; b=WkngP9lb jJp9WPmTvWF5X6Ym5ngsxgH6Lc5Cl7cVufA9iAN1VYREeGzKLhJN86rWfaNh+H5s yGGKpNhrwn9TcCJM3y519oqXk3EWpaWzsz4knau490z7ySTpU5Im0xiU0Ur/L+rK sFun+UKcn11g8RHs8bNbJBJLftTUBNma6fbKPbO/w+3LhRt14LAtdRDKlSMErQ99 HVHrQcwUWM7F5sQGBNcK8COl4coL57kyiqerFCy/f3LDqC3g05weP3qS8JjSjxhh WmMudxmO/bR6L7MSBYQ+Tg4kYVVRFZFB6ivMGmU27VGqoD02xtDJfObr7hVF6W6x 6uotyT41F6aj5Q== X-ME-Sender: X-Sasl-enc: lAqKsvcluvT2jozgKXF19jo7P28iC70T1zuZekyom5Ib 1500648787 Received: from xps.localnet (bzq-164-168-31-206.red.bezeqint.net [31.168.164.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 934467E17D; Fri, 21 Jul 2017 10:53:07 -0400 (EDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: dev@dpdk.org, nic@opencloud.tech Date: Fri, 21 Jul 2017 17:53:01 +0300 Message-ID: <1688226.sl7kgNVU6i@xps> In-Reply-To: <20170721091119.15701-1-sergio.gonzalez.monroy@intel.com> References: <20170721091119.15701-1-sergio.gonzalez.monroy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pci: limit default numa node to used devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2017 14:53:08 -0000 The title and the text below should explain that you move the warning log from scan to probe, thanks to a temporary negative value. 21/07/2017 12:11, Sergio Gonzalez Monroy: > Commit 8a04cb612589 ("pci: set default numa node for broken systems") > added logic to default to NUMA node 0 when sysfs numa_node information > was wrong or not available. > > Unfortunately there are many devices with wrong NUMA node information > that DPDK does not care about but still show warnings for them. > > Instead, only check for invalid NUMA node information for devices > managed by the DPDK. > > Signed-off-by: Sergio Gonzalez Monroy [...] > - if (eal_parse_sysfs_value(filename, &tmp) == 0 && > - tmp < RTE_MAX_NUMA_NODES) > + if (eal_parse_sysfs_value(filename, &tmp) == 0) > dev->device.numa_node = tmp; Why are you removing the check of the value? Are you going to accept invalid high values? This check was introduced on purpose by this commit: http://dpdk.org/commit/8a04cb6125