From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id C09601D28D
 for <dev@dpdk.org>; Fri,  6 Apr 2018 17:57:25 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B1AFA20EC6;
 Fri,  6 Apr 2018 11:57:24 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 06 Apr 2018 11:57:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Tcz6qN2WYipYcaQfCO/srmdjZd
 9jVMYQ+gwSDEXFQhQ=; b=UeATWcfS8iVj/mEdPYJAAVjPVOuLcEPgsERP+QGRiG
 GnlqfXFWMAhOf2oTqMzMLxFOVTzvaVHbrFhfusCRjGupbMLKrX++lYK6WCl1IEYs
 NXDBaWrIls2+fqhytLEPq2d8JgUOi2gamuPPLP68ovJQzzSOX5kIFfaGW3ULiXaB
 8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Tcz6qN
 2WYipYcaQfCO/srmdjZd9jVMYQ+gwSDEXFQhQ=; b=iqrGSFRr4GuGRngxoqMqwG
 K40wmU7TgSQKMBNIhoAVdvs9aoeH808RTr2ugcEZzEEyvc1TLQYuLS/oINkUeG81
 5pBj/eCq0c2C77KE/XmqxJTR6CcyHwdD/QTZRCXIupKddQ8K0oY2jlwTdOkYC3O4
 mGlS/2t6dtT2w4W7eeS17Jk946ox0mAuc6GAGYkGFySMv2hEPBPmLr38EKsfYyAm
 VQzgy7A6cJCJyh5vJRTjMKkOfvUHF5bteV949bAHEEXZcpSCNR+n+13aGR65suc/
 o1xE8X/dxUFRjbScThxBQcwtCENm4PXjAS68L4sWuJFjprNa5ulGOtjULnaunF5w
 ==
X-ME-Sender: <xms:5JjHWqeTbtF-u_EbZRdYzYtzyQxU2IiSb_oXhoyCqMFh8Q1H2gWNIQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E8413E47F2;
 Fri,  6 Apr 2018 11:57:22 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Cc: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org,
 Alex Rosenbaum <alexr@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Remy Horton <remy.horton@intel.com>, John McNamara <john.mcnamara@intel.com>,
 Rony Efraim <ronye@mellanox.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Yuanhan Liu <yliu@fridaylinux.org>,
 Bruce Richardson <bruce.richardson@intel.com>
Date: Fri, 06 Apr 2018 17:57:23 +0200
Message-ID: <1688530.7oQI8JUYAQ@xps>
In-Reply-To: <90f813f1-6306-e6ed-26ea-4f0931bdebaf@intel.com>
References: <20180405135148.16388-1-declan.doherty@intel.com>
 <2392634.y0Dprd7BRi@xps> <90f813f1-6306-e6ed-26ea-4f0931bdebaf@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action
	items support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 15:57:26 -0000

06/04/2018 15:47, Mohammad Abdul Awal:
> 
> On 05/04/2018 17:49, Thomas Monjalon wrote:
> > 05/04/2018 15:51, Declan Doherty:
> >> +struct rte_flow_item_metadata {
> >> +       uint32_t id;            /**< field identifier */
> >> +       uint32_t size;          /**< field size */
> >> +       uint8_t bytes[];        /**< field value */
> >> +};
> > Spotted C99 syntax of flexible array.
> > Are we OK with all supported compilers?
> >
> Used "uint8_t *bytes;" instead of "uint8_t bytes[];"

Why this change? It is changing the size of the structure, isn't it?