From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Damjan Marion (damarion)" <damarion@cisco.com>
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
David Marchand <david.marchand@6wind.com>
Subject: Re: [dpdk-dev] spinlock: Move constructor function out of header file
Date: Fri, 15 Jul 2016 00:06:30 +0200 [thread overview]
Message-ID: <16886146.HTal4qelT5@xps13> (raw)
In-Reply-To: <CC779A8A-2F0B-4A0F-B812-94E9F69F28A6@cisco.com>
2016-07-14 18:10, Damjan Marion:
> Dear Jan,
>
> Thank you for your comments. A bit too much overhead to submit simple patch
> so let’s forget about it. I will just add it as it is to our private
> collection of patches.
These are changes trivial to fix when applying.
I strongly prefer that you upstream patches instead of keeping patches
in the VPP repository. I will help you in this task.
Thanks for the effort.
> If anybody wants to pick it from here, please do...
I can update the bsdapp Makefile and do the trivial changes for you,
if we agree that we do not need to touch to other archs (see below).
> > On 14 Jul 2016, at 20:03, Jan Viktorin <viktorin@rehivetech.com> wrote:
> >> --- a/lib/librte_eal/linuxapp/eal/Makefile
> >> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> >> @@ -106,6 +106,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_keepalive.c
> >>
> >> # from arch dir
> >> SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_cpuflags.c
> >> +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_spinlock.c
> >
> > This is not good, you provide rte_spinlock.c only for x86. Building
> > for any other arch would fail to find this file.
It is not used in other archs. It is really x86 specific.
> > Moreover, the bsdapp/eal/Makefile should reflect this situation as
> > well.
Good catch.
next prev parent reply other threads:[~2016-07-14 22:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:27 [dpdk-dev] [PATCH] " damarion
2016-07-14 18:03 ` [dpdk-dev] " Jan Viktorin
2016-07-14 18:10 ` Damjan Marion (damarion)
2016-07-14 22:06 ` Thomas Monjalon [this message]
2016-07-14 22:20 ` Damjan Marion (damarion)
2016-07-15 8:31 ` Thomas Monjalon
2016-07-15 9:54 ` Damjan Marion (damarion)
2016-07-15 10:09 ` Thomas Monjalon
2016-07-16 11:12 ` Damjan Marion (damarion)
2016-07-16 11:14 ` Damjan Marion (damarion)
2016-07-15 14:37 ` Thomas Monjalon
2016-07-15 15:08 ` Thomas Monjalon
2016-07-16 11:14 ` Damjan Marion (damarion)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16886146.HTal4qelT5@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=damarion@cisco.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).