From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 9E89837A4 for ; Fri, 15 Jul 2016 00:06:32 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id i5so5889172wmg.0 for ; Thu, 14 Jul 2016 15:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=JnvxsUv1gxrHuCV09cpC60J9Q5WkyfuVhJyxx4bLkjg=; b=TlH4NNHGqV6BnZSTIOZelEqR7NCHS3eBp7O3IE6NxFj+VsxQ2IrPD62y1yw8/a1lMY lT7c95aS2F3SaAI343b3Cm/w3/gFR6Yp7zXpiEr5FlmBS3H/xv58Y8oO8k4Rni6oi6FD //cqbwOpoxksNZUPsf1R7s6YdcxpAbGD8V2mU5c0YFNaTBI5JPQ8yONwdaaEX/IvwZOE hqDCePI+keNYn9f8d3X8jHlpQeVFpXkUoEv+ywGyOW2NeNEvDCNvnmUNMfIo3amD1tn3 wLvfGgmHUgMwUOx9j2V0TbgAfNzLq3LNU75F4ePQmAt+8q6nCvcy9sI45banxODrkUeP vcHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=JnvxsUv1gxrHuCV09cpC60J9Q5WkyfuVhJyxx4bLkjg=; b=NQ4UXdE2Xnh6k3GbXedOBC2Iklepk/Ip6whMNdFLaDEyqvezIM9tXMUEhdn3g+rgmS vDYlhwJGRVAb8oIWplhEQVORGr02bGeEP047kYPQfO8pibKpqKfkjCJ+MyIZMnr3a0mo AoFAVa9xcOntuMIgBHUITHIJqMD8bJf6QHFW/6rArexIFhAU7misnTa3T8RoTWBnFODK FZ/Hh3nklNiVKiyP5u7CSquyGWUkVIpmg61s+aI8eqU0XqnS1U2I/7wzre6YCP2q31nr UNGvq0hu7Um5aC34cQu/pZXbMPUfTTEaetsAfwWq+W88p27sX17SMqa9JegtjNzx2KeU JhFg== X-Gm-Message-State: ALyK8tL6qXBnOfEaPVorWynFuSn5toh3y/jt6MFAuvPbkRUtAjyjjHL3B+uJAj6IhfR5c08T X-Received: by 10.28.38.5 with SMTP id m5mr37036123wmm.82.1468533992406; Thu, 14 Jul 2016 15:06:32 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q23sm724921wme.17.2016.07.14.15.06.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jul 2016 15:06:31 -0700 (PDT) From: Thomas Monjalon To: "Damjan Marion (damarion)" Cc: dev@dpdk.org, Jan Viktorin , Bruce Richardson , Konstantin Ananyev , David Marchand Date: Fri, 15 Jul 2016 00:06:30 +0200 Message-ID: <16886146.HTal4qelT5@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20160714132729.27024-1-damarion@cisco.com> <20160714200336.119bcfce@jvn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] spinlock: Move constructor function out of header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 22:06:32 -0000 2016-07-14 18:10, Damjan Marion: > Dear Jan, >=20 > Thank you for your comments. A bit too much overhead to submit simple= patch > so let=E2=80=99s forget about it. I will just add it as it is to our = private > collection of patches. These are changes trivial to fix when applying. I strongly prefer that you upstream patches instead of keeping patches in the VPP repository. I will help you in this task. Thanks for the effort. > If anybody wants to pick it from here, please do... I can update the bsdapp Makefile and do the trivial changes for you, if we agree that we do not need to touch to other archs (see below). > > On 14 Jul 2016, at 20:03, Jan Viktorin wr= ote: > >> --- a/lib/librte_eal/linuxapp/eal/Makefile > >> +++ b/lib/librte_eal/linuxapp/eal/Makefile > >> @@ -106,6 +106,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D rte_= keepalive.c > >>=20 > >> # from arch dir > >> SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D rte_cpuflags.c > >> +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D rte_spinlock.c > >=20 > > This is not good, you provide rte_spinlock.c only for x86. Building= > > for any other arch would fail to find this file. It is not used in other archs. It is really x86 specific. > > Moreover, the bsdapp/eal/Makefile should reflect this situation as > > well. Good catch.