From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, thomas@monjalon.net,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v2] provide Windows/MSVC lcore macros
Date: Tue, 11 Jul 2023 08:52:26 -0700 [thread overview]
Message-ID: <1689090747-5331-1-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1689024585-17303-1-git-send-email-roretzla@linux.microsoft.com>
Provide MSVC compatible macros RTE_DEFINE_PER_LCORE and
RTE_DECLARE_PER_LCORE that expand appropriately for Windows/MSVC
NOTICE:
It is intentional that devtools/checkpatches.pl generates an error
about parenthesis to allow comparison with clang/gcc versions of
these macros which also do not have the parenthesis.
```
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parenthesis
#31: FILE: lib/eal/include/rte_per_lcore.h:42:
+#define RTE_DEFINE_PER_LCORE(type, name) \
+ __declspec(thread) typeof(type) per_lcore_##name
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parenthesis
#34: FILE: lib/eal/include/rte_per_lcore.h:45:
+#define RTE_DECLARE_PER_LCORE(type, name) \
+ extern __declspec(thread) typeof(type) per_lcore_##name
```
v2:
* invert macro test for msvc #ifndef -> #ifdef
Tyler Retzlaff (1):
eal: provide per lcore macros for MSVC
lib/eal/include/rte_per_lcore.h | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--
1.8.3.1
next prev parent reply other threads:[~2023-07-11 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 21:29 [PATCH] " Tyler Retzlaff
2023-07-10 21:29 ` [PATCH] eal: provide per lcore macros for MSVC Tyler Retzlaff
2023-07-11 6:25 ` Thomas Monjalon
2023-07-11 15:52 ` Tyler Retzlaff [this message]
2023-07-11 15:52 ` [PATCH v2] " Tyler Retzlaff
2023-07-11 16:09 ` Stephen Hemminger
2023-08-25 8:49 ` David Marchand
2023-08-31 11:57 ` Thomas Monjalon
2023-08-31 23:08 ` Tyler Retzlaff
2023-09-21 9:36 ` Thomas Monjalon
2023-09-21 15:45 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1689090747-5331-1-git-send-email-roretzla@linux.microsoft.com \
--to=roretzla@linux.microsoft.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).