From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3321BA059B; Fri, 10 Apr 2020 10:56:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C93B1D406; Fri, 10 Apr 2020 10:56:30 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 82A081D17C for ; Fri, 10 Apr 2020 10:56:28 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DC5975C01E7; Fri, 10 Apr 2020 04:56:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 10 Apr 2020 04:56:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2IuYtHahOvgXvmFd+vWdMT0tCmOfK7nDrA8yro9DaAg=; b=ijzDQIGq6AvU oACr+JZBnpeYj1SKTU0uEk26e8vwdQy0KhGD6AmYIpnQL374HFjPazTxxVCa846e JkK8/PNHVfE7wu1mbVxC0E9DLmmFLsbzHm9IZDWj3vu9eRsFxW1tPongMkAPe0yx XzCfjBKPbhbWDzhlf++f8eb2vZX0SzA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2IuYtHahOvgXvmFd+vWdMT0tCmOfK7nDrA8yro9Da Ag=; b=bg9BkuNHK6/QVhg8VWfoj/HJ7u/uOiEx9cW07v3BYUix0hHj4sWc2SA0R FKe9wzRkShk0qlk0G5WhqCfxc/GLjdsLKvLFDVYy5KKBDWXxllq9jMHskncE/pFU 2dDo6eHJelCgtfgbr87WXaoArqtxfN1B60udjANlHwsG7UKODc4OrqfSDsqJBGZs ogPsCL4K56qn4iyTcV1cwF13o37fkBdwYhuLN2wnR1oGIJKPe1S4/vsC5EQGDVsT wqPWjGAZyo5DyEit+qfGlJhRv2LMFAsOeO9p/sRpMGCH3IEi5kn671Nb1a6JBd/u odt8gFOm3IHED+Y5NcLVkOhwVLZ8A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddvgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5365B3280068; Fri, 10 Apr 2020 04:56:26 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , Ferruh Yigit Cc: John McNamara , Marko Kovacevic , dpdk-dev , Andrew Rybchenko , Adrien Mazarguil , Ajit Khaparde , Jerin Jacob , Ori Kam Date: Fri, 10 Apr 2020 10:56:25 +0200 Message-ID: <1689523.vCJZsxu672@thomas> In-Reply-To: <5defdf9b-7c1d-f4e2-9bd7-6de55ef452e5@intel.com> References: <20191025125118.47189-1-ferruh.yigit@intel.com> <5defdf9b-7c1d-f4e2-9bd7-6de55ef452e5@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2020 10:44, Ferruh Yigit: > On 10/25/2019 2:39 PM, Jerin Jacob wrote: > > On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon wrote: > >> > >> 25/10/2019 14:51, Ferruh Yigit: > >>> "Flow API" is a method/API to implement various filtering features, on > >>> its own it doesn't give much context on what features are provided. And > >>> it is not really a feature, so doesn't fit into feature table. > >>> > >>> Also since other filtering related APIs, 'filter_ctrl', has been > >>> deprecated, flow API is the only supported way in the DPDK to implement > >>> filtering options, if related filter options announced by PMDs, listing > >>> "Flow API" as implemented is redundant information. > >> > >> I fully agree with this explanation. > >> rte_flow is the only supported API for flow offloads. > >> That's why we must remove the legacy API. > >> > >>> Signed-off-by: Ferruh Yigit > >>> --- > >>> --- a/doc/guides/nics/features/default.ini > >>> +++ b/doc/guides/nics/features/default.ini > >>> -Flow API = > >> > >> Acked-by: Thomas Monjalon > > > > # Need to remove "Flow API" from doc/guides/nics/features.rst > > +1 > > > # Need to remove refference of "Flow API" from "doc/guides/nics/*" as well. > > "Flow API" is the implementation of the filtering, it may exist in the nic > documentation, only it is not a feature on itself. I will scan the docs for usage. > > > > > Not specific to this patch, > > Probably we need to add a new matrix to enumerate PATTERN and ACTIONS > > supported by each PMD as a rte_flow feature matrix. > > That some else can take it up if everyone agrees the semantics. > > > > +1, there needs a way to figure out which filtering is supported by a > device/driver. It is not documented and it is very hard to got it from the code. > > Not sure if a new matrix is the good way to go, but I agree we need some way to > clarify it. I think we should split the matrix. Adding a new matrix for flow offloads looks the way to go. I suggest 3 matrices: - port-level features - queue-level features - flow-level features